qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Edmondson <david.edmondson@oracle.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>,
	Leonardo Bras <leobras@redhat.com>, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH 2/2] migration: Put zero_pages in alphabetical order
Date: Thu, 04 May 2023 13:38:14 +0100	[thread overview]
Message-ID: <m2h6ss5l1l.fsf@oracle.com> (raw)
In-Reply-To: <20230504103357.22130-3-quintela@redhat.com>

Juan Quintela <quintela@redhat.com> writes:

> I forgot to move it when I rename it from duplicated_pages.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
>  migration/migration-stats.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/migration/migration-stats.h b/migration/migration-stats.h
> index 0e49c236fa..b87ba30ea8 100644
> --- a/migration/migration-stats.h
> +++ b/migration/migration-stats.h
> @@ -48,10 +48,6 @@ typedef struct {
>       * guest is stopped.
>       */
>      Stat64 downtime_bytes;
> -    /*
> -     * number of pages transferred that were full of zeros.
> -     */
> -    Stat64 zero_pages;
>      /*
>       * number of bytes sent through multifd channels.
>       */
> @@ -77,6 +73,10 @@ typedef struct {
>       * total number of bytes transferred.
>       */
>      Stat64 transferred;
> +    /*
> +     * number of pages transferred that were full of zeros.
> +     */
> +    Stat64 zero_pages;
>  } MigrationAtomicStats;
>  
>  extern MigrationAtomicStats mig_stats;
> -- 
> 2.40.0
-- 
I've got a little black book with my poems in.


  reply	other threads:[~2023-05-04 17:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04 10:33 [PATCH 0/2] More migration stats Juan Quintela
2023-05-04 10:33 ` [PATCH 1/2] migration: Document all migration_stats Juan Quintela
2023-05-04 12:37   ` David Edmondson
2023-05-04 17:38     ` Juan Quintela
2023-05-04 16:47   ` Daniel P. Berrangé
2023-05-04 17:39     ` Juan Quintela
2023-05-04 10:33 ` [PATCH 2/2] migration: Put zero_pages in alphabetical order Juan Quintela
2023-05-04 12:38   ` David Edmondson [this message]
2023-05-04 16:47   ` Daniel P. Berrangé
2023-05-25 15:06   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2h6ss5l1l.fsf@oracle.com \
    --to=david.edmondson@oracle.com \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).