From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1OBKCx-0003mK-CL for qemu-devel@nongnu.org; Mon, 10 May 2010 00:03:07 -0400 Received: from [140.186.70.92] (port=44358 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBKCs-0003mC-07 for qemu-devel@nongnu.org; Mon, 10 May 2010 00:03:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBKCh-0003B6-SK for qemu-devel@nongnu.org; Mon, 10 May 2010 00:03:01 -0400 Received: from mail-qy0-f188.google.com ([209.85.221.188]:62716) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBKCh-0003AP-Oi for qemu-devel@nongnu.org; Mon, 10 May 2010 00:02:51 -0400 Received: by qyk26 with SMTP id 26so5277909qyk.19 for ; Sun, 09 May 2010 21:02:50 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4BE686C5.4030302@mail.berlios.de> References: <4BE686C5.4030302@mail.berlios.de> Date: Mon, 10 May 2010 12:02:49 +0800 Message-ID: Subject: Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc From: yajin Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: chen huacai , qemu-devel@nongnu.org > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_spciconf_readw': I think TARGET_FMT_plx should be used instead of using %llx to avoid this warning. yajin http://vm-kernel.org 2010/5/9 Stefan Weil : > Am 09.05.2010 04:00, schrieb chen huacai: >> >> This patch add initial support of bonito north bridge used by fulong mini >> pc >> >> Signed-off-by: Huacai Chen >> > > ... >> >> + >> +} BonitoState; >> + >> +BonitoState * bonito_state; >> > > Add static attribute? > > With DEBUG enabled, I get a lot of compiler warnings: > > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_writeb': > /home/stefan/src/qemu/hw/bonito.c:232: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_writew': > /home/stefan/src/qemu/hw/bonito.c:239: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_writel': > /home/stefan/src/qemu/hw/bonito.c:252: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_readb': > /home/stefan/src/qemu/hw/bonito.c:313: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_readw': > /home/stefan/src/qemu/hw/bonito.c:321: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_readl': > /home/stefan/src/qemu/hw/bonito.c:334: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_pciconf_writeb': > /home/stefan/src/qemu/hw/bonito.c:364: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_pciconf_writew': > /home/stefan/src/qemu/hw/bonito.c:371: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_pciconf_writel': > /home/stefan/src/qemu/hw/bonito.c:384: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_pciconf_readb': > /home/stefan/src/qemu/hw/bonito.c:393: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_pciconf_readw': > /home/stefan/src/qemu/hw/bonito.c:400: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_pciconf_readl': > /home/stefan/src/qemu/hw/bonito.c:414: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_localio_readb': > /home/stefan/src/qemu/hw/bonito.c:441: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_localio_readw': > /home/stefan/src/qemu/hw/bonito.c:451: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_localio_readl': > /home/stefan/src/qemu/hw/bonito.c:465: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_localio_writeb': > /home/stefan/src/qemu/hw/bonito.c:478: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_localio_writew': > /home/stefan/src/qemu/hw/bonito.c:487: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_localio_writel': > /home/stefan/src/qemu/hw/bonito.c:499: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_spciconf_writeb': > /home/stefan/src/qemu/hw/bonito.c:621: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_spciconf_writew': > /home/stefan/src/qemu/hw/bonito.c:639: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_spciconf_writel': > /home/stefan/src/qemu/hw/bonito.c:659: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_spciconf_readb': > /home/stefan/src/qemu/hw/bonito.c:677: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_spciconf_readw': > /home/stefan/src/qemu/hw/bonito.c:693: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_spciconf_readl': > /home/stefan/src/qemu/hw/bonito.c:711: error: format '%llx' expects type > 'long long unsigned int', but argument 2 has type 'target_phys_addr_t' > > > >