From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NxjMw-0003sY-6Y
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:05:14 -0400
Received: from [140.186.70.92] (port=44242 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NxjMr-0003py-5J
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:05:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1NxjMm-0003ck-AB
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:05:05 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:48087)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1NxjMm-0003cf-4A
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:05:04 -0400
Received: by pvc21 with SMTP id 21so922757pvc.4
	for <qemu-devel@nongnu.org>; Fri, 02 Apr 2010 09:05:03 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4BB610A7.8010006@redhat.com>
References: <1270219540-30027-1-git-send-email-pbonzini@redhat.com>
	<4BB60BB9.2050301@codemonkey.ws> <4BB610A7.8010006@redhat.com>
Date: Fri, 2 Apr 2010 19:05:03 +0300
Message-ID: <m2kf43fc5581004020905ye50f1213ve4d5b0ab4159a6d4@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] provide opaque CPUState to files that are
	compiled once
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 4/2/10, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 04/02/2010 05:22 PM, Anthony Liguori wrote:
>
>
> > hw/* should never access CPUState.
> >
> > Can you give examples of when qemu-kvm needs this?
> >
>
>  Indirectly via header files.  The problem is that GCC poisoning complains
> on prototypes too.
>
>  qemu-kvm.h references CPUState and includes cpu.h, so with the latest
> changes all files that include qemu-kvm.h break, even if they don't require
> qemu-kvm.h.  With this patch they instead get the opaque definition via
> hw/hw.h (which includes cpu-common.h), and qemu-kvm.h can avoid including
> cpu.h.

This is why I added #ifndef NEED_CPU_H to kvm.h.

>  Another example is the new apic.h file created by Blue Swirl.  It
> references CPUState.  It includes apic_get_irq_delivered, so I placed
> apic_set_irq_delivered there too.  But apic_set_irq_delivered is used by
> i8259.c which is compiled once.

But i8259.c is compiled per target, grep Makefile.target?

>  There are other similar cases.  Without something like this patch as a
> stopgap measure, you have to make everything compile again per-target which
> is a huge mess of conflicts.

This is wrong. There are lot of other ways to handle the need without
resorting to per-target build.