From: David Edmondson <dme@dme.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>
Subject: Re: [PATCH] hw/elf_ops: Fix a typo
Date: Wed, 03 Mar 2021 08:18:51 +0000 [thread overview]
Message-ID: <m2sg5clkes.fsf@dme.org> (raw)
In-Reply-To: <20210225181344.3623720-1-philmd@redhat.com>
On Thursday, 2021-02-25 at 19:13:44 +01, Philippe Mathieu-Daudé wrote:
> g_mapped_file_new_from_fd()'s parameter is named 'writable'.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: David Edmondson <dme@dme.org>
> ---
> include/hw/elf_ops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h
> index 8e8436831d2..304f266bf3b 100644
> --- a/include/hw/elf_ops.h
> +++ b/include/hw/elf_ops.h
> @@ -417,7 +417,7 @@ static int glue(load_elf, SZ)(const char *name, int fd,
>
> /*
> * Since we want to be able to modify the mapped buffer, we set the
> - * 'writeble' parameter to 'true'. Modifications to the buffer are not
> + * 'writable' parameter to 'true'. Modifications to the buffer are not
> * written back to the file.
> */
> mapped_file = g_mapped_file_new_from_fd(fd, true, NULL);
> --
> 2.26.2
dme.
--
I've always been mad, I know I've been mad, like the most of us are.
next prev parent reply other threads:[~2021-03-03 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 18:13 [PATCH] hw/elf_ops: Fix a typo Philippe Mathieu-Daudé
2021-02-25 21:39 ` Stefano Garzarella
2021-03-03 8:18 ` David Edmondson [this message]
2021-03-09 20:28 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sg5clkes.fsf@dme.org \
--to=dme@dme.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).