From: Schspa Shi <schspa@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/1] hw/arm/boot: set initrd with #[address/size]-cells type in fdt
Date: Tue, 29 Nov 2022 19:46:41 +0800 [thread overview]
Message-ID: <m2v8mym16c.fsf@gmail.com> (raw)
In-Reply-To: <84913eb8-75c3-5175-401f-9f4cc8409442@linaro.org>
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 29/11/22 11:48, Schspa Shi wrote:
>> We use 32bit value for linux,initrd-[start/end], when we have
>> loader_start > 4GB, there will be a wrong initrd_start passed
>> to the kernel, and the kernel will report the following warning.
>> [ 0.000000] ------------[ cut here ]------------
>> [ 0.000000] initrd not fully accessible via the linear mapping -- please check your bootloader ...
>> [ 0.000000] WARNING: CPU: 0 PID: 0 at arch/arm64/mm/init.c:355 arm64_memblock_init+0x158/0x244
>> [ 0.000000] Modules linked in:
>> [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 6.1.0-rc3-13250-g30a0b95b1335-dirty #28
>> [ 0.000000] Hardware name: Horizon Sigi Virtual development board (DT)
>> [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
>> [ 0.000000] pc : arm64_memblock_init+0x158/0x244
>> [ 0.000000] lr : arm64_memblock_init+0x158/0x244
>> [ 0.000000] sp : ffff800009273df0
>> [ 0.000000] x29: ffff800009273df0 x28: 0000001000cc0010 x27: 0000800000000000
>> [ 0.000000] x26: 000000000050a3e2 x25: ffff800008b46000 x24: ffff800008b46000
>> [ 0.000000] x23: ffff800008a53000 x22: ffff800009420000 x21: ffff800008a53000
>> [ 0.000000] x20: 0000000004000000 x19: 0000000004000000 x18: 00000000ffff1020
>> [ 0.000000] x17: 6568632065736165 x16: 6c70202d2d20676e x15: 697070616d207261
>> [ 0.000000] x14: 656e696c20656874 x13: 0a2e2e2e20726564 x12: 0000000000000000
>> [ 0.000000] x11: 0000000000000000 x10: 00000000ffffffff x9 : 0000000000000000
>> [ 0.000000] x8 : 0000000000000000 x7 : 796c6c756620746f x6 : 6e20647274696e69
>> [ 0.000000] x5 : ffff8000093c7c47 x4 : ffff800008a2102f x3 : ffff800009273a88
>> [ 0.000000] x2 : 80000000fffff038 x1 : 00000000000000c0 x0 : 0000000000000056
>> [ 0.000000] Call trace:
>> [ 0.000000] arm64_memblock_init+0x158/0x244
>> [ 0.000000] setup_arch+0x164/0x1cc
>> [ 0.000000] start_kernel+0x94/0x4ac
>> [ 0.000000] __primary_switched+0xb4/0xbc
>> [ 0.000000] ---[ end trace 0000000000000000 ]---
>> [ 0.000000] Zone ranges:
>> [ 0.000000] DMA [mem 0x0000001000000000-0x0000001007ffffff]
>> To fix it, we can change it to #[address/size]-cells type.
>> Signed-off-by: Schspa Shi <schspa@gmail.com>
>>
>
> Something is odd with this patch, using Thunderbird + Colored Diffs add-on can't
> see the patch content, but I can see it archived:
> https://lore.kernel.org/qemu-devel/20221129104809.84860-1-schspa@gmail.com/
>
> Maybe because you used '--' instead of the git '---' separator?
This maybe cause by the seprator above the Change log line.
I use '-- ' as seprator.
Should I resend a new V3 patch to fix this ?
--
BRs
Schspa Shi
next prev parent reply other threads:[~2022-11-29 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 10:48 [PATCH v2 1/1] hw/arm/boot: set initrd with #[address/size]-cells type in fdt Schspa Shi
2022-11-29 11:07 ` Philippe Mathieu-Daudé
2022-11-29 11:46 ` Schspa Shi [this message]
2022-11-29 14:48 ` Peter Maydell
2022-11-29 16:07 ` Schspa Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2v8mym16c.fsf@gmail.com \
--to=schspa@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).