From: David Edmondson <david.edmondson@oracle.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Stephen Checkoway" <stephen.checkoway@oberlin.edu>,
qemu-block@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 3/9] hw/block/pflash_cfi02: Extract pflash_cfi02_fill_cfi_table()
Date: Wed, 10 Mar 2021 10:53:06 +0000 [thread overview]
Message-ID: <m2v99zfffx.fsf@oracle.com> (raw)
In-Reply-To: <20210309235028.912078-4-philmd@redhat.com>
On Wednesday, 2021-03-10 at 00:50:22 +01, Philippe Mathieu-Daudé wrote:
> Fill the CFI table in out of DeviceRealize() in a new function:
> pflash_cfi02_fill_cfi_table().
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> ---
> hw/block/pflash_cfi02.c | 193 +++++++++++++++++++++-------------------
> 1 file changed, 99 insertions(+), 94 deletions(-)
>
> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
> index fa981465e12..845f50ed99b 100644
> --- a/hw/block/pflash_cfi02.c
> +++ b/hw/block/pflash_cfi02.c
> @@ -724,6 +724,104 @@ static const MemoryRegionOps pflash_cfi02_ops = {
> .endianness = DEVICE_NATIVE_ENDIAN,
> };
>
> +static void pflash_cfi02_fill_cfi_table(PFlashCFI02 *pfl, int nb_regions)
> +{
> + /* Hardcoded CFI table (mostly from SG29 Spansion flash) */
> + const uint16_t pri_ofs = 0x40;
> + /* Standard "QRY" string */
> + pfl->cfi_table[0x10] = 'Q';
> + pfl->cfi_table[0x11] = 'R';
> + pfl->cfi_table[0x12] = 'Y';
> + /* Command set (AMD/Fujitsu) */
> + pfl->cfi_table[0x13] = 0x02;
> + pfl->cfi_table[0x14] = 0x00;
> + /* Primary extended table address */
> + pfl->cfi_table[0x15] = pri_ofs;
> + pfl->cfi_table[0x16] = pri_ofs >> 8;
> + /* Alternate command set (none) */
> + pfl->cfi_table[0x17] = 0x00;
> + pfl->cfi_table[0x18] = 0x00;
> + /* Alternate extended table (none) */
> + pfl->cfi_table[0x19] = 0x00;
> + pfl->cfi_table[0x1A] = 0x00;
> + /* Vcc min */
> + pfl->cfi_table[0x1B] = 0x27;
> + /* Vcc max */
> + pfl->cfi_table[0x1C] = 0x36;
> + /* Vpp min (no Vpp pin) */
> + pfl->cfi_table[0x1D] = 0x00;
> + /* Vpp max (no Vpp pin) */
> + pfl->cfi_table[0x1E] = 0x00;
> + /* Timeout per single byte/word write (128 ms) */
> + pfl->cfi_table[0x1F] = 0x07;
> + /* Timeout for min size buffer write (NA) */
> + pfl->cfi_table[0x20] = 0x00;
> + /* Typical timeout for block erase (512 ms) */
> + pfl->cfi_table[0x21] = 0x09;
> + /* Typical timeout for full chip erase (4096 ms) */
> + pfl->cfi_table[0x22] = 0x0C;
> + /* Reserved */
> + pfl->cfi_table[0x23] = 0x01;
> + /* Max timeout for buffer write (NA) */
> + pfl->cfi_table[0x24] = 0x00;
> + /* Max timeout for block erase */
> + pfl->cfi_table[0x25] = 0x0A;
> + /* Max timeout for chip erase */
> + pfl->cfi_table[0x26] = 0x0D;
> + /* Device size */
> + pfl->cfi_table[0x27] = ctz32(pfl->chip_len);
> + /* Flash device interface (8 & 16 bits) */
> + pfl->cfi_table[0x28] = 0x02;
> + pfl->cfi_table[0x29] = 0x00;
> + /* Max number of bytes in multi-bytes write */
> + /*
> + * XXX: disable buffered write as it's not supported
> + * pfl->cfi_table[0x2A] = 0x05;
> + */
> + pfl->cfi_table[0x2A] = 0x00;
> + pfl->cfi_table[0x2B] = 0x00;
> + /* Number of erase block regions */
> + pfl->cfi_table[0x2c] = nb_regions;
> + /* Erase block regions */
> + for (int i = 0; i < nb_regions; ++i) {
> + uint32_t sector_len_per_device = pfl->sector_len[i];
> + pfl->cfi_table[0x2d + 4 * i] = pfl->nb_blocs[i] - 1;
> + pfl->cfi_table[0x2e + 4 * i] = (pfl->nb_blocs[i] - 1) >> 8;
> + pfl->cfi_table[0x2f + 4 * i] = sector_len_per_device >> 8;
> + pfl->cfi_table[0x30 + 4 * i] = sector_len_per_device >> 16;
> + }
> + assert(0x2c + 4 * nb_regions < pri_ofs);
> +
> + /* Extended */
> + pfl->cfi_table[0x00 + pri_ofs] = 'P';
> + pfl->cfi_table[0x01 + pri_ofs] = 'R';
> + pfl->cfi_table[0x02 + pri_ofs] = 'I';
> +
> + /* Extended version 1.0 */
> + pfl->cfi_table[0x03 + pri_ofs] = '1';
> + pfl->cfi_table[0x04 + pri_ofs] = '0';
> +
> + /* Address sensitive unlock required. */
> + pfl->cfi_table[0x05 + pri_ofs] = 0x00;
> + /* Erase suspend to read/write. */
> + pfl->cfi_table[0x06 + pri_ofs] = 0x02;
> + /* Sector protect not supported. */
> + pfl->cfi_table[0x07 + pri_ofs] = 0x00;
> + /* Temporary sector unprotect not supported. */
> + pfl->cfi_table[0x08 + pri_ofs] = 0x00;
> +
> + /* Sector protect/unprotect scheme. */
> + pfl->cfi_table[0x09 + pri_ofs] = 0x00;
> +
> + /* Simultaneous operation not supported. */
> + pfl->cfi_table[0x0a + pri_ofs] = 0x00;
> + /* Burst mode not supported. */
> + pfl->cfi_table[0x0b + pri_ofs] = 0x00;
> + /* Page mode not supported. */
> + pfl->cfi_table[0x0c + pri_ofs] = 0x00;
> + assert(0x0c + pri_ofs < ARRAY_SIZE(pfl->cfi_table));
> +}
> +
> static void pflash_cfi02_realize(DeviceState *dev, Error **errp)
> {
> ERRP_GUARD();
> @@ -837,100 +935,7 @@ static void pflash_cfi02_realize(DeviceState *dev, Error **errp)
> pfl->cmd = 0;
> pfl->status = 0;
>
> - /* Hardcoded CFI table (mostly from SG29 Spansion flash) */
> - const uint16_t pri_ofs = 0x40;
> - /* Standard "QRY" string */
> - pfl->cfi_table[0x10] = 'Q';
> - pfl->cfi_table[0x11] = 'R';
> - pfl->cfi_table[0x12] = 'Y';
> - /* Command set (AMD/Fujitsu) */
> - pfl->cfi_table[0x13] = 0x02;
> - pfl->cfi_table[0x14] = 0x00;
> - /* Primary extended table address */
> - pfl->cfi_table[0x15] = pri_ofs;
> - pfl->cfi_table[0x16] = pri_ofs >> 8;
> - /* Alternate command set (none) */
> - pfl->cfi_table[0x17] = 0x00;
> - pfl->cfi_table[0x18] = 0x00;
> - /* Alternate extended table (none) */
> - pfl->cfi_table[0x19] = 0x00;
> - pfl->cfi_table[0x1A] = 0x00;
> - /* Vcc min */
> - pfl->cfi_table[0x1B] = 0x27;
> - /* Vcc max */
> - pfl->cfi_table[0x1C] = 0x36;
> - /* Vpp min (no Vpp pin) */
> - pfl->cfi_table[0x1D] = 0x00;
> - /* Vpp max (no Vpp pin) */
> - pfl->cfi_table[0x1E] = 0x00;
> - /* Timeout per single byte/word write (128 ms) */
> - pfl->cfi_table[0x1F] = 0x07;
> - /* Timeout for min size buffer write (NA) */
> - pfl->cfi_table[0x20] = 0x00;
> - /* Typical timeout for block erase (512 ms) */
> - pfl->cfi_table[0x21] = 0x09;
> - /* Typical timeout for full chip erase (4096 ms) */
> - pfl->cfi_table[0x22] = 0x0C;
> - /* Reserved */
> - pfl->cfi_table[0x23] = 0x01;
> - /* Max timeout for buffer write (NA) */
> - pfl->cfi_table[0x24] = 0x00;
> - /* Max timeout for block erase */
> - pfl->cfi_table[0x25] = 0x0A;
> - /* Max timeout for chip erase */
> - pfl->cfi_table[0x26] = 0x0D;
> - /* Device size */
> - pfl->cfi_table[0x27] = ctz32(pfl->chip_len);
> - /* Flash device interface (8 & 16 bits) */
> - pfl->cfi_table[0x28] = 0x02;
> - pfl->cfi_table[0x29] = 0x00;
> - /* Max number of bytes in multi-bytes write */
> - /*
> - * XXX: disable buffered write as it's not supported
> - * pfl->cfi_table[0x2A] = 0x05;
> - */
> - pfl->cfi_table[0x2A] = 0x00;
> - pfl->cfi_table[0x2B] = 0x00;
> - /* Number of erase block regions */
> - pfl->cfi_table[0x2c] = nb_regions;
> - /* Erase block regions */
> - for (int i = 0; i < nb_regions; ++i) {
> - uint32_t sector_len_per_device = pfl->sector_len[i];
> - pfl->cfi_table[0x2d + 4 * i] = pfl->nb_blocs[i] - 1;
> - pfl->cfi_table[0x2e + 4 * i] = (pfl->nb_blocs[i] - 1) >> 8;
> - pfl->cfi_table[0x2f + 4 * i] = sector_len_per_device >> 8;
> - pfl->cfi_table[0x30 + 4 * i] = sector_len_per_device >> 16;
> - }
> - assert(0x2c + 4 * nb_regions < pri_ofs);
> -
> - /* Extended */
> - pfl->cfi_table[0x00 + pri_ofs] = 'P';
> - pfl->cfi_table[0x01 + pri_ofs] = 'R';
> - pfl->cfi_table[0x02 + pri_ofs] = 'I';
> -
> - /* Extended version 1.0 */
> - pfl->cfi_table[0x03 + pri_ofs] = '1';
> - pfl->cfi_table[0x04 + pri_ofs] = '0';
> -
> - /* Address sensitive unlock required. */
> - pfl->cfi_table[0x05 + pri_ofs] = 0x00;
> - /* Erase suspend to read/write. */
> - pfl->cfi_table[0x06 + pri_ofs] = 0x02;
> - /* Sector protect not supported. */
> - pfl->cfi_table[0x07 + pri_ofs] = 0x00;
> - /* Temporary sector unprotect not supported. */
> - pfl->cfi_table[0x08 + pri_ofs] = 0x00;
> -
> - /* Sector protect/unprotect scheme. */
> - pfl->cfi_table[0x09 + pri_ofs] = 0x00;
> -
> - /* Simultaneous operation not supported. */
> - pfl->cfi_table[0x0a + pri_ofs] = 0x00;
> - /* Burst mode not supported. */
> - pfl->cfi_table[0x0b + pri_ofs] = 0x00;
> - /* Page mode not supported. */
> - pfl->cfi_table[0x0c + pri_ofs] = 0x00;
> - assert(0x0c + pri_ofs < ARRAY_SIZE(pfl->cfi_table));
> + pflash_cfi02_fill_cfi_table(pfl, nb_regions);
> }
>
> static Property pflash_cfi02_properties[] = {
> --
> 2.26.2
dme.
--
You took the words right out of my mouth.
next prev parent reply other threads:[~2021-03-10 10:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 23:50 [PATCH 0/9] hw/block/pflash: Refactors around setting the device in read-array mode Philippe Mathieu-Daudé
2021-03-09 23:50 ` [PATCH 1/9] hw/block/pflash_cfi: Fix code style for checkpatch.pl Philippe Mathieu-Daudé
2021-03-10 8:48 ` Bin Meng
2021-03-10 9:30 ` David Edmondson
2021-03-09 23:50 ` [PATCH 2/9] hw/block/pflash_cfi01: Extract pflash_cfi01_fill_cfi_table() Philippe Mathieu-Daudé
2021-03-10 8:48 ` Bin Meng
2021-03-10 9:31 ` David Edmondson
2021-03-09 23:50 ` [PATCH 3/9] hw/block/pflash_cfi02: Extract pflash_cfi02_fill_cfi_table() Philippe Mathieu-Daudé
2021-03-10 8:48 ` Bin Meng
2021-03-10 10:53 ` David Edmondson [this message]
2021-03-09 23:50 ` [PATCH 4/9] hw/block/pflash_cfi02: Set rom_mode to true in pflash_setup_mappings() Philippe Mathieu-Daudé
2021-03-10 8:48 ` Bin Meng
2021-03-10 10:58 ` David Edmondson
2021-03-10 16:34 ` Philippe Mathieu-Daudé
2021-03-09 23:50 ` [PATCH 5/9] hw/block/pflash_cfi02: Open-code pflash_register_memory(rom=false) Philippe Mathieu-Daudé
2021-03-10 8:48 ` Bin Meng
2021-03-09 23:50 ` [PATCH 6/9] hw/block/pflash_cfi02: Rename register_memory(true) as mode_read_array Philippe Mathieu-Daudé
2021-03-10 8:48 ` Bin Meng
2021-03-10 10:59 ` David Edmondson
2021-03-10 16:31 ` Philippe Mathieu-Daudé
2021-03-10 16:34 ` Philippe Mathieu-Daudé
2021-03-09 23:50 ` [PATCH 7/9] hw/block/pflash_cfi02: Factor out DeviceReset method Philippe Mathieu-Daudé
2021-03-10 8:48 ` Bin Meng
2021-03-10 16:44 ` Philippe Mathieu-Daudé
2021-03-10 11:01 ` David Edmondson
2021-03-09 23:50 ` [PATCH 8/9] hw/block/pflash_cfi01: Clarify trace events Philippe Mathieu-Daudé
2021-03-10 8:48 ` Bin Meng
2021-03-10 11:01 ` David Edmondson
2021-03-09 23:50 ` [PATCH 9/9] hw/block/pflash_cfi01: Extract pflash_mode_read_array() Philippe Mathieu-Daudé
2021-03-10 11:05 ` David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2v99zfffx.fsf@oracle.com \
--to=david.edmondson@oracle.com \
--cc=alistair.francis@wdc.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stephen.checkoway@oberlin.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).