From: MORITA Kazutaka <morita.kazutaka@gmail.com>
To: Liu Yuan <namei.unix@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
sheepdog@lists.wpkg.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: add discard/trim support for sheepdog
Date: Tue, 16 Apr 2013 01:03:32 +0900 [thread overview]
Message-ID: <m2zjwz6asr.wl%morita.kazutaka@gmail.com> (raw)
In-Reply-To: <1366041160-24919-1-git-send-email-namei.unix@gmail.com>
At Mon, 15 Apr 2013 23:52:40 +0800,
Liu Yuan wrote:
>
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 987018e..362244a 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -34,6 +34,7 @@
> #define SD_OP_GET_VDI_INFO 0x14
> #define SD_OP_READ_VDIS 0x15
> #define SD_OP_FLUSH_VDI 0x16
> +#define SD_OP_DISCARD_OBJ 0x17
I think SD_OP_DISCARD_OBJ should be 0x05 since we are using a value
less than 0x10 for SD_OP_*_OBJ.
The other parts look good to me.
Thanks,
Kazutaka
next prev parent reply other threads:[~2013-04-15 16:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 11:27 [Qemu-devel] [PATCH For SD and QEMU] Add discard/trim support for Sheepdog Liu Yuan
2013-04-13 11:27 ` [Qemu-devel] [PATCH 1/3] sheep: remove unused 'flags' in remove_object() Liu Yuan
2013-04-13 11:27 ` [Qemu-devel] [PATCH 2/3] sheep: teach sheep to discard unused objects Liu Yuan
2013-04-13 11:27 ` [Qemu-devel] [PATCH 3/3] tests: add 058 to test discard/trim Liu Yuan
2013-04-13 11:27 ` [Qemu-devel] [PATCH for QEMU] sheepdog: add discard/trim support for sheepdog Liu Yuan
2013-04-14 5:07 ` [Qemu-devel] [PATCH for QEMU v2] " Liu Yuan
2013-04-14 5:16 ` [Qemu-devel] [PATCH for QEMU v3] " Liu Yuan
2013-04-15 15:10 ` [Qemu-devel] [sheepdog] " MORITA Kazutaka
2013-04-15 15:52 ` [Qemu-devel] [PATCH v4] " Liu Yuan
2013-04-15 16:03 ` MORITA Kazutaka [this message]
2013-04-15 16:15 ` [Qemu-devel] [PATCH v5] " Liu Yuan
2013-04-15 16:25 ` [Qemu-devel] [sheepdog] " MORITA Kazutaka
2013-04-16 8:18 ` [Qemu-devel] " Stefan Hajnoczi
2013-04-16 8:47 ` Kevin Wolf
2013-04-16 9:08 ` Liu Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zjwz6asr.wl%morita.kazutaka@gmail.com \
--to=morita.kazutaka@gmail.com \
--cc=kwolf@redhat.com \
--cc=namei.unix@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sheepdog@lists.wpkg.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).