From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <morita.kazutaka@gmail.com>) id 1URlsZ-0003ei-36
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 12:03:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <morita.kazutaka@gmail.com>) id 1URlsX-0008NM-Bj
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 12:03:39 -0400
Received: from mail-pb0-f52.google.com ([209.85.160.52]:51658)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <morita.kazutaka@gmail.com>) id 1URlsX-0008N5-1Y
	for qemu-devel@nongnu.org; Mon, 15 Apr 2013 12:03:37 -0400
Received: by mail-pb0-f52.google.com with SMTP id mc8so2585983pbc.11
	for <qemu-devel@nongnu.org>; Mon, 15 Apr 2013 09:03:36 -0700 (PDT)
Date: Tue, 16 Apr 2013 01:03:32 +0900
Message-ID: <m2zjwz6asr.wl%morita.kazutaka@gmail.com>
From: MORITA Kazutaka <morita.kazutaka@gmail.com>
In-Reply-To: <1366041160-24919-1-git-send-email-namei.unix@gmail.com>
References: <1365852442-28941-5-git-send-email-namei.unix@gmail.com>
	<1366041160-24919-1-git-send-email-namei.unix@gmail.com>
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [Qemu-devel] [sheepdog] [PATCH v4] sheepdog: add discard/trim
	support for	sheepdog
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Yuan <namei.unix@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

At Mon, 15 Apr 2013 23:52:40 +0800,
Liu Yuan wrote:
> 
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 987018e..362244a 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -34,6 +34,7 @@
>  #define SD_OP_GET_VDI_INFO   0x14
>  #define SD_OP_READ_VDIS      0x15
>  #define SD_OP_FLUSH_VDI      0x16
> +#define SD_OP_DISCARD_OBJ    0x17

I think SD_OP_DISCARD_OBJ should be 0x05 since we are using a value
less than 0x10 for SD_OP_*_OBJ.

The other parts look good to me.

Thanks,

Kazutaka