From: Vincent Bernat <vincent@bernat.ch>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 1/2] hw/smbios: support for type 41 (onboard devices extended information)
Date: Thu, 01 Apr 2021 10:46:44 +0200 [thread overview]
Message-ID: <m31rbul7d7.fsf@bernat.ch> (raw)
In-Reply-To: <YGWHPWSrOLxEQtMA@redhat.com> ("Daniel P. Berrangé"'s message of "Thu, 1 Apr 2021 09:41:33 +0100")
❦ 1 avril 2021 09:41 +01, Daniel P. Berrangé:
>> + t = calloc(1, sizeof(struct type41_instance));
>> + if (!t) {
>> + error_setg(errp,
>> + "Unable to allocate memory for a new type 41 instance");
>> + return;
>> + }
>
> QEMU uses GLib allocation functions throughout, which abort
> on OOM. So replace this with g_new0.
Ack. Will be fixed on the next version. Thanks!
--
Make input easy to proofread.
- The Elements of Programming Style (Kernighan & Plauger)
prev parent reply other threads:[~2021-04-01 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 8:25 [PATCH v2 1/2] hw/smbios: support for type 41 (onboard devices extended information) Vincent Bernat
2021-04-01 8:25 ` [PATCH v2 2/2] hw/smbios: retrieve PCI address from specified device for Type 41 Vincent Bernat
2021-04-01 9:38 ` Daniel P. Berrangé
2021-04-01 10:07 ` Vincent Bernat
2021-04-01 10:19 ` Daniel P. Berrangé
2021-04-01 12:27 ` Vincent Bernat
2021-04-01 13:59 ` Michael S. Tsirkin
2021-04-01 14:26 ` Vincent Bernat
2021-04-01 16:32 ` Michael S. Tsirkin
2021-04-01 8:41 ` [PATCH v2 1/2] hw/smbios: support for type 41 (onboard devices extended information) Daniel P. Berrangé
2021-04-01 8:46 ` Vincent Bernat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31rbul7d7.fsf@bernat.ch \
--to=vincent@bernat.ch \
--cc=berrange@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).