From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MnIXn-0004OR-B3
	for qemu-devel@nongnu.org; Mon, 14 Sep 2009 16:53:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MnIXi-0004NU-OK
	for qemu-devel@nongnu.org; Mon, 14 Sep 2009 16:53:03 -0400
Received: from [199.232.76.173] (port=36953 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MnIXi-0004NN-JM
	for qemu-devel@nongnu.org; Mon, 14 Sep 2009 16:52:58 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <4AAEAC27.3070300@gnu.org> (Paolo Bonzini's message of "Mon, 14
	Sep 2009 22:48:39 +0200")
References: <cover.1252959221.git.quintela@redhat.com>
	<4AAEAC27.3070300@gnu.org>
Date: Mon, 14 Sep 2009 22:50:12 +0200
Message-ID: <m31vm9jlob.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 0/4] Fix VMState design flaws
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: qemu-devel@nongnu.org

Paolo Bonzini <bonzini@gnu.org> wrote:
>>    * Add version_id field to post_load().  Now we can assign default values
>>      in post_load for old versions of the state (ps2_kbd as example).
>
> While this is a good idea, why don't we first reset the devices upon
> load, which would also set the default values?...

It is safe to do that unconditionally?
If so, I am all for it.  We can:
- add reset field to vmstate
- add default values to some fields, if it makse sense (haven't yet
  looked at reset code).

Later, Juan.