From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MgQMf-0003TF-19
	for qemu-devel@nongnu.org; Wed, 26 Aug 2009 17:49:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MgQMZ-0003T2-O9
	for qemu-devel@nongnu.org; Wed, 26 Aug 2009 17:49:07 -0400
Received: from [199.232.76.173] (port=51202 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MgQMZ-0003Sz-Gh
	for qemu-devel@nongnu.org; Wed, 26 Aug 2009 17:49:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54150)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1MgQMY-0004fN-DU
	for qemu-devel@nongnu.org; Wed, 26 Aug 2009 17:49:03 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <fb412d760908261410q4613fa24w5cff66afd1756d4a@mail.gmail.com>
	(Hollis Blanchard's message of "Wed, 26 Aug 2009 14:10:27 -0700")
References: <cover.1249301360.git.quintela@redhat.com>
	<fb6652759c6a5f980d8abe72f5bbeb58f160fd10.1249301360.git.quintela@redhat.com>
	<fb412d760908261410q4613fa24w5cff66afd1756d4a@mail.gmail.com>
Date: Wed, 26 Aug 2009 23:46:37 +0200
Message-ID: <m31vmyfdtu.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 70/81] remove last 3 uses of :=,
	everywhere  else uses += or =
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hollis Blanchard <hollis@penguinppc.org>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Hollis Blanchard <hollis@penguinppc.org> wrote:
> On Mon, Aug 3, 2009 at 5:47 AM, Juan Quintela<quintela@redhat.com> wrote:
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>> =C2=A0Makefile.target | =C2=A0 =C2=A06 +++---
>> =C2=A01 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index a4d269d..6b3d40f 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -20,7 +20,7 @@ endif
>> =C2=A0PROGS=3D$(QEMU_PROG)
>>
>> =C2=A0ifeq ($(subst ppc64,ppc,$(ARCH))$(TARGET_BASE_ARCH),ppcppc)
>> -translate.o: QEMU_CFLAGS :=3D $(QEMU_CFLAGS) $(call cc-option, $(QEMU_C=
FLAGS), -fno-unit-at-a-time,)
>> +translate.o: QEMU_CFLAGS +=3D $(call cc-option, $(QEMU_CFLAGS), -fno-un=
it-at-a-time,)
>> =C2=A0endif
>>
>> =C2=A0LIBS+=3D-lm
>
> This change breaks the build with PPC host and PPC target:
> Makefile:25: *** Recursive variable `QEMU_CFLAGS' references itself
> (eventually).  Stop.
>
> I don't know why you want to remove all :=3D, but it seems like this
> hunk should be reverted.

Could you check two things:

a- remove the whole block, it should not be needed anymore (or that I
   have been told)
b- if a) don't work, tryng to change the interior bit to

translate.o: QEMU_CFLAGS +=3D $(call cc-option, $(CFLAGS),-fno-unit-at-a-ti=
me,)

And if so, we can do this change.  What we pass as 2nd argument
shouldn't matter for this test.

call cc-option is complicated to get right, sorry :(

Later, Juan.