From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NuYuo-0000p1-Ul
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 18:19:06 -0400
Received: from [140.186.70.92] (port=47245 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NuYum-0000nz-E0
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 18:19:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1NuYuk-00055g-I4
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 18:19:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43220)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1NuYuk-00055b-9L
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 18:19:02 -0400
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2OMJ1mN017951
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 24 Mar 2010 18:19:01 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1269460245-31941-1-git-send-email-kraxel@redhat.com> (Gerd
	Hoffmann's message of "Wed, 24 Mar 2010 20:50:45 +0100")
References: <1269460245-31941-1-git-send-email-kraxel@redhat.com>
Date: Wed, 24 Mar 2010 23:18:59 +0100
Message-ID: <m339zptlbg.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH v2] update bochs vbe interface
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> wrote:
> The bochs vbe interface got a new register a while back, which specifies
> the linear framebuffer size in 64k units.  This patch adds support for
> the new register to qemu.  With this patch applied vgabios 0.6c works
> with qemu.
>
> [ v2:  Don't savevm the new register.  Doing so breaks migration,
>        and as it carries read-only information for the guest there
>        is no need to save it. ]


It don't compile (as expected).  VMSTATE_UINT16_ARRAY() checks that you
sent the whole array.


/mnt/kvm/qemu/qemu-negotiate/hw/vga.c:2219: error: invalid operands to bina=
ry - (have =E2=80=98uint16_t (*)[10]=E2=80=99 and =E2=80=98uint16_t (*)[11]=
=E2=80=99)
make[1]: *** [vga.o] Error 1
make[1]: *** Waiting for unfinished jobs....
^Cmake[1]: *** [translate.o] Interrupt
make[1]: *** [op_helper.o] Interrupt
make: *** [subdir-x86_64-softmmu] Interrupt

> ---
>  hw/vga.c     |    5 +++--
>  hw/vga_int.h |    6 +++++-
>  2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/hw/vga.c b/hw/vga.c
> index 6a1a059..f9e07cf 100644
> --- a/hw/vga.c
> +++ b/hw/vga.c
> @@ -1955,7 +1955,8 @@ void vga_common_reset(VGACommonState *s)
>  #ifdef CONFIG_BOCHS_VBE
>      s->vbe_index =3D 0;
>      memset(s->vbe_regs, '\0', sizeof(s->vbe_regs));
> -    s->vbe_regs[VBE_DISPI_INDEX_ID] =3D VBE_DISPI_ID0;
> +    s->vbe_regs[VBE_DISPI_INDEX_ID] =3D VBE_DISPI_ID5;

Now, to show my ignorance, what does this change means?

I can't understand it looking at the whole file (but I don't understand
vga.c too well anyways).

Later, Juan.