qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] Sparc32/PPC: convert escc to qdev
Date: Wed, 15 Jul 2009 00:03:42 +0200	[thread overview]
Message-ID: <m33a8y3osh.fsf@neno.mitica> (raw)
In-Reply-To: <f43fc5580907141154q4206f8b9s408e475b3f94846a@mail.gmail.com> (Blue Swirl's message of "Tue\, 14 Jul 2009 21\:54\:52 +0300")

Blue Swirl <blauwirbel@gmail.com> wrote:
> On 7/14/09, Juan Quintela <quintela@trasno.org> wrote:
>> Blue Swirl <blauwirbel@gmail.com> wrote:

I didn't explain myself enough, I guess.

>>  > +    qdev_set_prop_int(dev, "frequency", clock);
                                   ^^^^^^^^^
....
>>  > +    clock = qdev_get_prop_int(&dev->qdev, "clock", 0);
                                                  ^^^^^

You are setting a property named "frequency" and read a property named
"clock" :)  I just asked to use the same property in both places.

Later, Juan.

  reply	other threads:[~2009-07-14 22:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13 19:32 [Qemu-devel] [PATCH] Sparc32/PPC: convert escc to qdev Blue Swirl
     [not found] ` <m3k52c8evv.fsf@neno.mitica>
2009-07-14 18:54   ` [Qemu-devel] " Blue Swirl
2009-07-14 22:03     ` Juan Quintela [this message]
2009-07-15 14:47       ` Blue Swirl
2009-07-15 15:37         ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m33a8y3osh.fsf@neno.mitica \
    --to=quintela@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).