From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MQq9t-0001Ho-5x
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 18:07:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MQq9o-0001AC-JW
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 18:07:32 -0400
Received: from [199.232.76.173] (port=57612 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MQq9o-0001A2-GB
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 18:07:28 -0400
Received: from mx2.redhat.com ([66.187.237.31]:59974)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1MQq9n-0001sZ-TB
	for qemu-devel@nongnu.org; Tue, 14 Jul 2009 18:07:28 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <f43fc5580907141154q4206f8b9s408e475b3f94846a@mail.gmail.com>
	(Blue Swirl's message of "Tue\, 14 Jul 2009 21\:54\:52 +0300")
References: <f43fc5580907131232m1f3e95d5h178b097cf6845930@mail.gmail.com>
	<m3k52c8evv.fsf@neno.mitica>
	<f43fc5580907141154q4206f8b9s408e475b3f94846a@mail.gmail.com>
Date: Wed, 15 Jul 2009 00:03:42 +0200
Message-ID: <m33a8y3osh.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH] Sparc32/PPC: convert escc to qdev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>

Blue Swirl <blauwirbel@gmail.com> wrote:
> On 7/14/09, Juan Quintela <quintela@trasno.org> wrote:
>> Blue Swirl <blauwirbel@gmail.com> wrote:

I didn't explain myself enough, I guess.

>>  > +    qdev_set_prop_int(dev, "frequency", clock);
                                   ^^^^^^^^^
....
>>  > +    clock = qdev_get_prop_int(&dev->qdev, "clock", 0);
                                                  ^^^^^

You are setting a property named "frequency" and read a property named
"clock" :)  I just asked to use the same property in both places.

Later, Juan.