From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NkbRw-0002ic-FB
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:00:08 -0500
Received: from [199.232.76.173] (port=35844 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NkbRu-0002iS-J9
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:00:06 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <quintela@redhat.com>) id 1NkbRr-0006fn-B8
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:00:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57724)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1NkbRq-0006f5-91
	for qemu-devel@nongnu.org; Thu, 25 Feb 2010 06:00:03 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1PAxjGL023981
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 25 Feb 2010 05:59:45 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1267087161-15204-3-git-send-email-kraxel@redhat.com> (Gerd
	Hoffmann's message of "Thu, 25 Feb 2010 09:39:19 +0100")
References: <1267087161-15204-1-git-send-email-kraxel@redhat.com>
	<1267087161-15204-3-git-send-email-kraxel@redhat.com>
Date: Thu, 25 Feb 2010 11:59:44 +0100
Message-ID: <m34ol5r36n.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 2/4] kbd leds: ps/2 kbd
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> wrote:
> Add led status notification support to the ps/2 kbd driver.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/ps2.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ps2.c b/hw/ps2.c
> index 15a6650..3dc3b15 100644
> --- a/hw/ps2.c
> +++ b/hw/ps2.c
> @@ -185,6 +185,7 @@ static void ps2_reset_keyboard(PS2KbdState *s)
>  {
>      s->scan_enabled = 1;
>      s->scancode_set = 2;
> +    kbd_put_ledstate(0);
>  }
>  
>  void ps2_write_keyboard(void *opaque, int val)
> @@ -259,6 +260,7 @@ void ps2_write_keyboard(void *opaque, int val)
>          s->common.write_cmd = -1;
>          break;
>      case KBD_CMD_SET_LEDS:
> +        kbd_put_ledstate(val);

You need a comment here, stating that the new QEMU_*_LOCK_LED values are the same
than the ps2 ones.

>          ps2_queue(&s->common, KBD_REPLY_ACK);
>          s->common.write_cmd = -1;
>          break;

Agreed with the rest of the changes.