From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44369 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJqcT-0001m9-Dv for qemu-devel@nongnu.org; Wed, 02 Jun 2010 12:16:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJqcS-0006rK-8Z for qemu-devel@nongnu.org; Wed, 02 Jun 2010 12:16:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20630) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJqcS-0006rA-2V for qemu-devel@nongnu.org; Wed, 02 Jun 2010 12:16:40 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o52GGdC9026073 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 2 Jun 2010 12:16:39 -0400 From: Markus Armbruster References: <1275478317-1989-1-git-send-email-armbru@redhat.com> <1275478317-1989-4-git-send-email-armbru@redhat.com> <4C067E45.1050801@redhat.com> Date: Wed, 02 Jun 2010 18:16:36 +0200 In-Reply-To: <4C067E45.1050801@redhat.com> (Kevin Wolf's message of "Wed, 02 Jun 2010 17:52:37 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 3/3] blockdev: Collect block device code in new blockdev.c List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Kevin Wolf writes: > Am 02.06.2010 13:31, schrieb Markus Armbruster: >> Anything that moves hundreds of lines out of vl.c can't be all bad. >> >> Signed-off-by: Markus Armbruster > > New files need a license header, otherwise it looks ok. > > I have applied this patch (and the other ones, too) to the block branch > anyway to avoid conflicts with other people basing their patches on that > branch. However, it requires a v2 before I can propose this to be merged > into master. vl.c has "Copyright (c) 2003-2008 Fabrice Bellard". monitor.c has "Copyright (c) 2003-2004 Fabrice Bellard". Would the following header do? /* * QEMU host block devices * * Copyright (c) 2003-2008 Fabrice Bellard * * This work is licensed under the terms of the GNU GPL, version 2 or * later. See the COPYING file in the top-level directory. */