From: Juan Quintela <quintela@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, paulus@samba.org,
anton@samba.org, Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-serial: Fix endianness bug in the config space
Date: Mon, 25 Apr 2011 18:40:03 +0200 [thread overview]
Message-ID: <m37hainv30.fsf@neno.mitica> (raw)
In-Reply-To: <1303178626-30268-1-git-send-email-david@gibson.dropbear.id.au> (David Gibson's message of "Tue, 19 Apr 2011 12:03:46 +1000")
David Gibson <david@gibson.dropbear.id.au> wrote:
> From: Alexey Kardashevskiy <aik@ozlabs.ru>
>
> The virtio serial specification requres that the values in the config
> space are encoded in native endian of the guest.
> The qemu virtio-serial code did not do conversion to the guest endian
> format what caused problems when host and guest use different format.
>
> This patch corrects the qemu side, correctly doing host-native <->
> guest-native conversions when accessing the config space. This won't
> break any setups that aren't already broken, and fixes the case
> of different host and guest endianness.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Juan Quintela <quintela@redhat.com>
It dont' make any change when guest & host has the same endianess.
Later, Juan.
prev parent reply other threads:[~2011-04-25 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 2:03 [Qemu-devel] [PATCH] virtio-serial: Fix endianness bug in the config space David Gibson
2011-04-20 12:36 ` Amit Shah
2011-04-20 14:51 ` David Gibson
2011-04-25 16:40 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37hainv30.fsf@neno.mitica \
--to=quintela@redhat.com \
--cc=aik@ozlabs.ru \
--cc=amit.shah@redhat.com \
--cc=anton@samba.org \
--cc=david@gibson.dropbear.id.au \
--cc=paulus@samba.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).