From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEOq2-0000oT-45 for qemu-devel@nongnu.org; Mon, 25 Apr 2011 12:40:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEOq0-0003HJ-Vj for qemu-devel@nongnu.org; Mon, 25 Apr 2011 12:40:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEOq0-0003Gu-Ms for qemu-devel@nongnu.org; Mon, 25 Apr 2011 12:40:40 -0400 From: Juan Quintela In-Reply-To: <1303178626-30268-1-git-send-email-david@gibson.dropbear.id.au> (David Gibson's message of "Tue, 19 Apr 2011 12:03:46 +1000") References: <1303178626-30268-1-git-send-email-david@gibson.dropbear.id.au> Date: Mon, 25 Apr 2011 18:40:03 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] virtio-serial: Fix endianness bug in the config space Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, paulus@samba.org, anton@samba.org, Amit Shah David Gibson wrote: > From: Alexey Kardashevskiy > > The virtio serial specification requres that the values in the config > space are encoded in native endian of the guest. > The qemu virtio-serial code did not do conversion to the guest endian > format what caused problems when host and guest use different format. > > This patch corrects the qemu side, correctly doing host-native <-> > guest-native conversions when accessing the config space. This won't > break any setups that aren't already broken, and fixes the case > of different host and guest endianness. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Juan Quintela It dont' make any change when guest & host has the same endianess. Later, Juan.