From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40922 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PKzJ3-0008Gb-Vm
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 15:17:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PKzJ2-0002qO-QR
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 15:17:37 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53696)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PKzJ2-0002pd-Gx
	for qemu-devel@nongnu.org; Tue, 23 Nov 2010 15:17:36 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oANKHWNK010267
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 23 Nov 2010 15:17:32 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <20101123200240.GA4436@redhat.com> (Michael S. Tsirkin's message
	of "Tue, 23 Nov 2010 22:02:40 +0200")
References: <20101123200240.GA4436@redhat.com>
Date: Tue, 23 Nov 2010 21:17:26 +0100
Message-ID: <m37hg394mh.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH] virtio: fix up VQ checks
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

"Michael S. Tsirkin" <mst@redhat.com> wrote:
> When migration triggers before a VQ is initialized,
> base pa is 0 and last_used_index must be 0 too:
> we don't have a ring to compare to.
>
> This fixes a bug introduced in
> 258dc7c96bb4b7ca71d5bee811e73933310e168c.
>
> Reporrted-by: Juan Quintela <quintela@redhat.com>

extra 'r'

> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Compile-tested only.
> Juan, could you tell me whether this fixes the bug
> you see please?

Fixes it.