From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8Mc0-0001dq-12 for qemu-devel@nongnu.org; Wed, 11 Nov 2009 18:28:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8Mbv-0001Qi-01 for qemu-devel@nongnu.org; Wed, 11 Nov 2009 18:28:27 -0500 Received: from [199.232.76.173] (port=44990 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8Mbu-0001QU-Sd for qemu-devel@nongnu.org; Wed, 11 Nov 2009 18:28:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36518) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8Mbu-0008D6-G3 for qemu-devel@nongnu.org; Wed, 11 Nov 2009 18:28:22 -0500 From: Juan Quintela In-Reply-To: <4AFB4059.8020607@web.de> (Jan Kiszka's message of "Wed, 11 Nov 2009 23:53:13 +0100") References: <4AFB4059.8020607@web.de> Date: Thu, 12 Nov 2009 00:28:01 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH] fdc: Fix vmsave/restore regression List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Blue Swirl , qemu-devel , Gerd Hoffmann Jan Kiszka wrote: > This partly reverts 2be3783328: First, the conversion neglected to > update the opaque translation in fdc_pre_save/fdc_post_load which causes > memory corruptions on vmsave/restore. And second, we can't apply a > common translation here as DeviceState->fdctrl_t is different for sysbus > and ISA. I finished today the proper patch. Please don't apply this one. > Signed-off-by: Jan Kiszka > --- > > hw/fdc.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > *** NOTE *** > 'git shortlog|grep "reset + vmsd"' shows 10 such conversions. I only > briefly checked the first one, and it looks similar broken. Could > someone have a second look at them? Maybe it is also better to define a > vmsd opaque in DeviceInfo, which would also allow to solve this issue > differently. It looks like a plan. I am in the middle of trying to get migration working, and have at least another 2 patches (appart from the one already in staging). I am in the last round of testing. Later, Juan.