From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33651 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2N8I-0003p9-Ua for qemu-devel@nongnu.org; Wed, 23 Mar 2011 08:25:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q2N8H-0007lJ-2x for qemu-devel@nongnu.org; Wed, 23 Mar 2011 08:25:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q2N8G-0007km-QR for qemu-devel@nongnu.org; Wed, 23 Mar 2011 08:25:49 -0400 From: Juan Quintela In-Reply-To: <20110310082349.GD17376@amit-x200.redhat.com> (Amit Shah's message of "Thu, 10 Mar 2011 13:53:49 +0530") References: <20110310082349.GD17376@amit-x200.redhat.com> Date: Wed, 23 Mar 2011 13:24:06 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PULL (resend, rebase) 2/5] virtio-serial: Disallow generic ports at id 0 Reply-To: quintela@redhat.com List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu list Amit Shah wrote: > On (Thu) 10 Mar 2011 [11:39:16], Amit Shah wrote: >> Port 0 is reserved for virtconsole devices for backward compatibility >> with the old -virtioconsole (from qemu 0.12) device type. >> >> libvirt prior to commit 8e28c5d40200b4c5d483bd585d237b9d870372e5 used >> port 0 for generic ports. libvirt will no longer do that, but disallow >> instantiating generic ports at id 0 from qemu as well. >> >> Signed-off-by: Amit Shah > > Updated patch below, fixes a build break after rebase. The git tree > in the pull request has been updated with this fix. Reviewed-by: Juan Quintela