From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57181 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOaFu-0005OO-Va
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 13:49:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OOaCd-0005AY-KH
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 13:45:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61852)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OOaCd-0005AP-DO
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 13:45:35 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH RFC] Mark a device as non-migratable
References: <4C16558A.5010005@codemonkey.ws>
	<1276618603-24184-1-git-send-email-cam@cs.ualberta.ca>
	<4C17AB1C.7010701@codemonkey.ws>
Date: Tue, 15 Jun 2010 19:45:30 +0200
In-Reply-To: <4C17AB1C.7010701@codemonkey.ws> (Anthony Liguori's message of
	"Tue, 15 Jun 2010 11:32:28 -0500")
Message-ID: <m3bpbcqjet.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Cam Macdonell <cam@cs.ualberta.ca>, qemu-devel@nongnu.org, kvm@vger.kernel.org

Anthony Liguori <anthony@codemonkey.ws> writes:

> On 06/15/2010 11:16 AM, Cam Macdonell wrote:
>> How does this look for marking the device as non-migratable?  It adds a field
>> 'no_migrate' to the SaveStateEntry and tests for it in vmstate_save.  This would
>> replace anything that touches memory.
>>
>> Cam
>>
>> ---
>>   hw/hw.h  |    1 +
>>   savevm.c |   32 +++++++++++++++++++++++++++++---
>>   2 files changed, 30 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/hw.h b/hw/hw.h
>> index d78d814..7c93f08 100644
>> --- a/hw/hw.h
>> +++ b/hw/hw.h
>> @@ -263,6 +263,7 @@ int register_savevm_live(const char *idstr,
>>                            void *opaque);
>>
>>   void unregister_savevm(const char *idstr, void *opaque);
>> +void mark_no_migrate(const char *idstr, void *opaque);
>>    
>
> I'm not thrilled with the name but the functionality is spot on.  I
> lack the creativity to offer a better name suggestion :-)

Tongue firmly in cheek: mark_sedentary()?