From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVQ2Q-0005Hm-7Y
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:14:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVQ2L-0005Bq-KW
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:14:45 -0400
Received: from [199.232.76.173] (port=42610 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVQ2L-0005BM-DA
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:14:41 -0400
Received: from mx2.redhat.com ([66.187.237.31]:33439)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1MVQ2K-0004EN-Qf
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 09:14:41 -0400
In-Reply-To: <20090724204628.GU32566@codesourcery.com> (Nathan Froyd's message
	of "Fri\, 24 Jul 2009 13\:46\:28 -0700")
References: <cover.1248459711.git.quintela@redhat.com>
	<22a7a2be00a22a4ab3bbb4fdc634ab7aaacd8d6e.1248459711.git.quintela@redhat.com>
	<20090724204628.GU32566@codesourcery.com>
From: Juan Quintela <quintela@redhat.com>
Date: Mon, 27 Jul 2009 15:10:45 +0200
Message-ID: <m3bpn6uv8q.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to
	CONFIG_MACHINE_BSWAP_H
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-devel@nongnu.org

Nathan Froyd <froydnj@codesourcery.com> wrote:
> On Fri, Jul 24, 2009 at 08:30:22PM +0200, Juan Quintela wrote:
>> @@ -176,7 +176,7 @@ VPATH+=:$(SRC_PATH)/linux-user:$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>>  CPPFLAGS+=-I$(SRC_PATH)/linux-user -I$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>>
>>  ifeq ($(ARCH),i386)
>> -ifdef TARGET_GPROF
>> +ifdef CONFIG_GPROF
>>  USE_I386_LD=y
>>  endif
>>  ifdef CONFIG_STATIC
>
> I don't see anything obviously wrong with the rest of the patch, but
> this hunk and others make it look like you forgot to split out a patch
> in your patch series.

Split in two patches.  thanks.

Once there, thought it again, and decided that TARGET_GPROF was a better
name than CONFIG_GPROF.

Later, Juan.