From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXZL5-0006PR-5a for qemu-devel@nongnu.org; Thu, 24 May 2012 10:48:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXZKw-0007U0-Pw for qemu-devel@nongnu.org; Thu, 24 May 2012 10:48:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXZKw-0007Tp-Ho for qemu-devel@nongnu.org; Thu, 24 May 2012 10:48:22 -0400 From: Markus Armbruster References: <1337859784-24097-1-git-send-email-armbru@redhat.com> <4FBE2A59.3060701@suse.de> <4FBE4625.9040703@suse.de> Date: Thu, 24 May 2012 16:48:18 +0200 In-Reply-To: <4FBE4625.9040703@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?= =?utf-8?Q?'s?= message of "Thu, 24 May 2012 16:31:01 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws Andreas F=C3=A4rber writes: > Am 24.05.2012 16:08, schrieb Markus Armbruster: >> Andreas F=C3=A4rber writes: >>=20 >>> Am 24.05.2012 13:43, schrieb Markus Armbruster: >>>> Beware: second patch is the product of voodoo-coding. >>> >>> Hm, I don't like the voodoo. ;) I would rather expose a proper C API >>> like object_try_new(const char *, Error **) than opening up the TypeImpl >>> internals to the public and hand-coding it everywhere. >>=20 >> How does returning a TypeImpl * open up TypeImpl any more than >> type_register() already does? > > type_register[_static]() operates on TypeInfo, not TypeImpl. > > I consider TypeImpl an implementation detail of qom/object.c, but maybe > I'm mistaken. They return TypeImpl *, just like type_get_by_name(). [...]