From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46087 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PpHok-0001ep-Dr for qemu-devel@nongnu.org; Tue, 15 Feb 2011 05:07:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PpHoj-000331-CE for qemu-devel@nongnu.org; Tue, 15 Feb 2011 05:07:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PpHoj-00032k-28 for qemu-devel@nongnu.org; Tue, 15 Feb 2011 05:07:33 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 06/10] vmmouse: convert to qdev References: <4D57FBCD.5060209@codemonkey.ws> Date: Tue, 15 Feb 2011 11:07:13 +0100 In-Reply-To: <4D57FBCD.5060209@codemonkey.ws> (Anthony Liguori's message of "Sun, 13 Feb 2011 09:42:05 -0600") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , qemu-devel Anthony Liguori writes: > On 02/12/2011 11:03 AM, Markus Armbruster wrote: >> Blue Swirl writes: >> >> >>> Convert to qdev, also add a proper reset function. [...] >> Pointer properties are for dirty hacks only. Is there really no better >> solution? Why does it have to be a property? >> > > vmmouse is really just an extension to the PS2 Mouse. It's definitely > not an ISA device. > > In terms of qdev enablement, I would just make it a boolean option to > the PS2Mouse and not expose it as a top level device at all. It > cannot exist without a PS2Mouse. Which means making it a separate qdev is wrong. That wrongness gave rise to the dirty pointer property. Pointer property serves as canary again. What now? PS: Grumpy reviewer venting: review can keep such mistakes out of the code, but it got committed less than two days after it was posted. That, and the lack of proper reference headers bounced it several places down my review queue.