From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [PATCH 11/11] mips: avoid write only variables
Date: Thu, 07 Oct 2010 14:35:50 +0200 [thread overview]
Message-ID: <m3eic2fae1.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <4CAD76C2.1060605@redhat.com> (Paolo Bonzini's message of "Thu, 07 Oct 2010 09:29:06 +0200")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 10/06/2010 11:34 PM, Blue Swirl wrote:
>> Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
>> /src/qemu/target-mips/translate.c: In function 'gen_ld':
>> /src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set
>> but not used [-Werror=unused-but-set-variable]
>>
>> Fix by making the variable declarations and uses conditional to debugging.
>
> What about a set_opn macro instead of this one-off "D" idiom?
Even simpler: a few judiciously placed (void)opn.
prev parent reply other threads:[~2010-10-07 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 21:34 [Qemu-devel] [PATCH 11/11] mips: avoid write only variables Blue Swirl
2010-10-07 7:29 ` [Qemu-devel] " Paolo Bonzini
2010-10-07 12:35 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eic2fae1.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).