From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MgFZo-0001AT-Ig for qemu-devel@nongnu.org; Wed, 26 Aug 2009 06:18:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MgFZk-00016o-RN for qemu-devel@nongnu.org; Wed, 26 Aug 2009 06:18:00 -0400 Received: from [199.232.76.173] (port=47775 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MgFZk-00016b-Eq for qemu-devel@nongnu.org; Wed, 26 Aug 2009 06:17:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35426) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MgFZk-0004ih-0X for qemu-devel@nongnu.org; Wed, 26 Aug 2009 06:17:56 -0400 From: Juan Quintela In-Reply-To: <4A9508AC.5070205@redhat.com> (Gerd Hoffmann's message of "Wed, 26 Aug 2009 12:04:28 +0200") References: <1251224190-2423-1-git-send-email-quintela@redhat.com> <4A9508AC.5070205@redhat.com> Date: Wed, 26 Aug 2009 12:15:33 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH] Compile usb_ohci only for targets that need it List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann wrote: > On 08/25/09 20:16, Juan Quintela wrote: >> It is only needed for arm, ppc and sh4. > > Ahem. It works just fine on a pc too. And once qdev-ified you can > even add it via -device. > > While it probably makes sense to not build it by default because we > use uhci for pc I certainly want to have the option to include it. > > What is the long-term plan this stuff? I think it isn't useful to > hard-code all this in configure. How about having a > target-$arch/default-config file with 'CONFIG_FOO=y' lines? Also look > for (and prefer if present) a target-$arch/user-config file? > > cheers, > Gerd Same thing complained by Anthony yesterday at irc. Yet knew approach: a new config-devices.mak file with a new configuration system: vi/emacs, you select your poison checking that the configuration is valid: by now: you try to compile it, and if it works great, if it don't work, that was a bad configuration. Will let the creation of tools to a second phase. 1st one is to create a file where all devices are configured for each target. Current thing that I am doing is similar to what you propose: default-configs/ /config-devices.mak if it don't exist, it get copied from default-configs/ one What do you think? Later, Juan.