From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MdSxf-0002Dz-6R for qemu-devel@nongnu.org; Tue, 18 Aug 2009 13:59:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MdSxa-00027i-Dg for qemu-devel@nongnu.org; Tue, 18 Aug 2009 13:59:06 -0400 Received: from [199.232.76.173] (port=39323 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MdSxa-00027Z-9V for qemu-devel@nongnu.org; Tue, 18 Aug 2009 13:59:02 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48507) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MdSxZ-0007hS-Lb for qemu-devel@nongnu.org; Tue, 18 Aug 2009 13:59:01 -0400 From: Juan Quintela In-Reply-To: (Blue Swirl's message of "Tue, 18 Aug 2009 20:13:47 +0300") Date: Tue, 18 Aug 2009 19:56:45 +0200 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH 4/5] New VMstate save/load infrastructure List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org Reply-to: quintela@redhat.com Blue Swirl wrote: > On Tue, Aug 18, 2009 at 4:34 PM, Juan Quintela wrote: >> This patch introduces VMState infrastructure, to convert the save/load >> functions of devices to a table approach. =C2=A0This new approach has the >> advantages: >> - it is type-safe >> - you can't have load/save functions out of sync >> - will allows us to have new interesting commands, like dump , t= hat >> =C2=A0shows all its internal state. >> - Just now, the only added type is arrays, but we can add structures. > > I think all the structures should be 'const'. This is doable, and will do. > Also VMStateField and > VMStateDescription should be private to savevm.c. They can, as we are trying to create them statically, not programatically. Later, Juan.