From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MeAhw-0002KV-Od
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 12:41:48 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MeAhs-00021b-11
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 12:41:48 -0400
Received: from [199.232.76.173] (port=54692 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MeAhr-00020v-Sg
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 12:41:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3077)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1MeAhr-0005KP-BP
	for qemu-devel@nongnu.org; Thu, 20 Aug 2009 12:41:43 -0400
Received: from int-mx06.intmail.prod.int.phx2.redhat.com
	(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.19])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7KGfeSY013963
	for <qemu-devel@nongnu.org>; Thu, 20 Aug 2009 12:41:40 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1250774546-18951-1-git-send-email-kraxel@redhat.com> (Gerd
	Hoffmann's message of "Thu, 20 Aug 2009 15:22:16 +0200")
References: <1250774546-18951-1-git-send-email-kraxel@redhat.com>
Date: Thu, 20 Aug 2009 18:39:25 +0200
Message-ID: <m3hbw2zbgi.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 0/10] ide: cleanup and splitting.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
> Next round of the ide cleanup and splitting series.  Changes:
>
>  * Creating ide-internal.h is a separate patch now.
>  * Comments of the new files have been fixed to actually describe
>    the file content instead of being a simple cut+paste from ide.c
>  * There is a new patch (last one) which moves all ide code into a
>    new hw/ide/ subdirectory as suggested by avi.

Acked-by: Juan Quintela <quintela@redhat.com>

Already liked the 1st series.  This one addresed all my nitpits.
Only one remained is that in the 1st patch, there are places with
whitesace/tab damage. (damage was already there).

In function ide_ioport_write()

-	ide_clear_hob(ide_if);
+	ide_clear_hob(bus);
         /* NOTE: data is written to the two drives */
-	ide_if[0].hob_feature = ide_if[0].feature;
-	ide_if[1].hob_feature = ide_if[1].feature;
-        ide_if[0].feature = val;
-        ide_if[1].feature = val;
+	bus->ifs[0].hob_feature = bus->ifs[0].feature;
+	bus->ifs[1].hob_feature = bus->ifs[1].feature;
+        bus->ifs[0].feature = val;
+        bus->ifs[1].feature = val;

If you have to respin the series, consider fixing it once that you are there.

Later, Juan.