From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKrKB-00031h-4U for qemu-devel@nongnu.org; Mon, 31 Oct 2011 08:50:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKrK5-0003IO-M9 for qemu-devel@nongnu.org; Mon, 31 Oct 2011 08:50:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKrK5-0003IG-EJ for qemu-devel@nongnu.org; Mon, 31 Oct 2011 08:50:41 -0400 From: Markus Armbruster References: <1320061773-10634-1-git-send-email-stefanha@linux.vnet.ibm.com> Date: Mon, 31 Oct 2011 13:50:34 +0100 In-Reply-To: <1320061773-10634-1-git-send-email-stefanha@linux.vnet.ibm.com> (Stefan Hajnoczi's message of "Mon, 31 Oct 2011 11:49:33 +0000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] hw/9pfs: use g_vasprintf() instead of rolling our own List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, "Aneesh Kumar K.V" Stefan Hajnoczi writes: > Markus Armbruster sent fixes for va_list vararg > issues in v9fs_string_alloc_printf(). It turns out the function > duplicates g_vasprintf() and can therefore be eliminated entirely. > > Signed-off-by: Stefan Hajnoczi > --- > hw/9pfs/virtio-9p.c | 103 ++------------------------------------------------- > 1 files changed, 4 insertions(+), 99 deletions(-) *Much* better. Reviewed-by: Markus Armbruster