From: Markus Armbruster <armbru@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with _FORTIFY_SOURCE
Date: Thu, 21 Jan 2010 10:28:25 +0100 [thread overview]
Message-ID: <m3ljfrdcxy.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <m3zl47rhwo.fsf@neno.neno> (Juan Quintela's message of "Thu, 21 Jan 2010 09:17:27 +0100")
Juan Quintela <quintela@redhat.com> writes:
> Gleb Natapov <gleb@redhat.com> wrote:
>> On Wed, Jan 20, 2010 at 09:14:03PM +0100, Juan Quintela wrote:
[...]
>>> diff --git a/block/vvfat.c b/block/vvfat.c
>>> index 063f731..df957e5 100644
>>> --- a/block/vvfat.c
>>> +++ b/block/vvfat.c
>>> @@ -868,7 +868,8 @@ static int init_directories(BDRVVVFATState* s,
>>> {
>>> direntry_t* entry=array_get_next(&(s->directory));
>>> entry->attributes=0x28; /* archive | volume label */
>>> - snprintf((char*)entry->name,11,"QEMU VVFAT");
>>> + memcpy(entry->name,"QEMU VVF",8);
>>> + memcpy(entry->extension,"AT ",3);
>>> }
>>>
>> Before the change extension was initialized to "AT\0" after it is "AT "
>
> it was paolo who told to do that change. entries are not 0 ended.
>
> that was his explanation.
Please mention this in the commit message.
next prev parent reply other threads:[~2010-01-21 9:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 20:13 [Qemu-devel] [PATCH v2 00/17] Fix compilation with _FORTIFY_SOURCE Juan Quintela
2010-01-20 20:13 ` [Qemu-devel] [PATCH 01/17] Introduce qemu_write_full() Juan Quintela
2010-01-20 20:13 ` [Qemu-devel] [PATCH 02/17] force to test result for qemu_write_full() Juan Quintela
2010-01-20 20:13 ` [Qemu-devel] [PATCH 03/17] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 04/17] block/cow.c: fix warnings " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 05/17] block/qcow.c: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 06/17] block/vmdk.o: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 07/17] block/vvfat.c: " Juan Quintela
2010-01-21 7:37 ` Gleb Natapov
2010-01-21 8:17 ` [Qemu-devel] " Juan Quintela
2010-01-21 8:18 ` Gleb Natapov
2010-01-21 9:28 ` Markus Armbruster [this message]
2010-01-20 20:14 ` [Qemu-devel] [PATCH 08/17] block/qcow2.c: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 09/17] net/slirp.c: fix warning " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 10/17] usb-linux.c: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 11/17] vl.c: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 12/17] monitor.c: fix warnings " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 13/17] linux-user/mmap.c: " Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 14/17] check pipe() return value Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 15/17] Enable _FORTIFY_SOURCE=2 Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 16/17] Check availavility of -fstack-protector-all Juan Quintela
2010-01-20 20:14 ` [Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error Juan Quintela
2010-01-25 8:53 ` Laurent Desnogues
-- strict thread matches above, loose matches on Subject: below --
2010-01-19 23:56 [Qemu-devel] [PATCH 00/17] Fix compilation with _FORTIFY_SOURCE Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 07/17] block/vvfat.c: fix warnings " Juan Quintela
2010-01-20 6:19 ` [Qemu-devel] " Kirill A. Shutemov
2010-01-20 10:33 ` Daniel P. Berrange
2010-01-20 11:09 ` Kirill A. Shutemov
2010-01-20 11:45 ` Kevin Wolf
2010-01-20 12:15 ` Markus Armbruster
2010-01-20 12:36 ` Kirill A. Shutemov
2010-01-20 13:03 ` Markus Armbruster
2010-01-20 13:08 ` Gleb Natapov
2010-01-20 14:02 ` Kirill A. Shutemov
2010-01-20 14:11 ` Gleb Natapov
2010-01-20 15:00 ` malc
2010-01-20 13:51 ` Kirill A. Shutemov
2010-01-20 14:42 ` Markus Armbruster
2010-01-20 16:16 ` Jamie Lokier
2010-01-20 15:59 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ljfrdcxy.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=gleb@redhat.com \
--cc=kirill@shutemov.name \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).