From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXtL7-0004Sd-Tq
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 04:28:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXtL3-0004Ol-SB
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 04:28:33 -0500
Received: from [199.232.76.173] (port=35599 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXtL3-0004Oc-N8
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 04:28:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59548)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NXtL2-0002cK-SY
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 04:28:29 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 07/17] block/vvfat.c: fix warnings with
	_FORTIFY_SOURCE
References: <cover.1264017981.git.quintela@redhat.com>
	<086f8b2c736cb88cf217fe10ab558eec92fc000d.1264017981.git.quintela@redhat.com>
	<20100121073727.GQ5238@redhat.com> <m3zl47rhwo.fsf@neno.neno>
Date: Thu, 21 Jan 2010 10:28:25 +0100
In-Reply-To: <m3zl47rhwo.fsf@neno.neno> (Juan Quintela's message of "Thu, 21
	Jan 2010 09:17:27 +0100")
Message-ID: <m3ljfrdcxy.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>

Juan Quintela <quintela@redhat.com> writes:

> Gleb Natapov <gleb@redhat.com> wrote:
>> On Wed, Jan 20, 2010 at 09:14:03PM +0100, Juan Quintela wrote:
[...]
>>> diff --git a/block/vvfat.c b/block/vvfat.c
>>> index 063f731..df957e5 100644
>>> --- a/block/vvfat.c
>>> +++ b/block/vvfat.c
>>> @@ -868,7 +868,8 @@ static int init_directories(BDRVVVFATState* s,
>>>      {
>>>  	direntry_t* entry=array_get_next(&(s->directory));
>>>  	entry->attributes=0x28; /* archive | volume label */
>>> -	snprintf((char*)entry->name,11,"QEMU VVFAT");
>>> +	memcpy(entry->name,"QEMU VVF",8);
>>> +	memcpy(entry->extension,"AT ",3);
>>>      }
>>> 
>> Before the change extension was initialized to "AT\0" after it is "AT "
>
> it was paolo who told to do that change.  entries are not 0 ended.
>
> that was his explanation.

Please mention this in the commit message.