* [Qemu-devel] [PATCH] isa: serial+parallel: fixup index property.
@ 2009-11-23 9:07 Gerd Hoffmann
2009-11-23 10:01 ` Markus Armbruster
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2009-11-23 9:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
The index property for both isa-serial and isa-parallel is declared as
hex number whereas it should be int. Fix it.
---
hw/parallel.c | 2 +-
hw/serial.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/parallel.c b/hw/parallel.c
index 5ae8348..12693d4 100644
--- a/hw/parallel.c
+++ b/hw/parallel.c
@@ -587,7 +587,7 @@ static ISADeviceInfo parallel_isa_info = {
.qdev.size = sizeof(ISAParallelState),
.init = parallel_isa_initfn,
.qdev.props = (Property[]) {
- DEFINE_PROP_HEX32("index", ISAParallelState, index, -1),
+ DEFINE_PROP_UINT32("index", ISAParallelState, index, -1),
DEFINE_PROP_HEX32("iobase", ISAParallelState, iobase, -1),
DEFINE_PROP_UINT32("irq", ISAParallelState, isairq, 7),
DEFINE_PROP_CHR("chardev", ISAParallelState, state.chr),
diff --git a/hw/serial.c b/hw/serial.c
index 0063260..e7538ac 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -900,7 +900,7 @@ static ISADeviceInfo serial_isa_info = {
.qdev.size = sizeof(ISASerialState),
.init = serial_isa_initfn,
.qdev.props = (Property[]) {
- DEFINE_PROP_HEX32("index", ISASerialState, index, -1),
+ DEFINE_PROP_UINT32("index", ISASerialState, index, -1),
DEFINE_PROP_HEX32("iobase", ISASerialState, iobase, -1),
DEFINE_PROP_UINT32("irq", ISASerialState, isairq, -1),
DEFINE_PROP_CHR("chardev", ISASerialState, state.chr),
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] isa: serial+parallel: fixup index property.
2009-11-23 9:07 [Qemu-devel] [PATCH] isa: serial+parallel: fixup index property Gerd Hoffmann
@ 2009-11-23 10:01 ` Markus Armbruster
0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2009-11-23 10:01 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
Gerd Hoffmann <kraxel@redhat.com> writes:
> The index property for both isa-serial and isa-parallel is declared as
> hex number whereas it should be int. Fix it.
Yes, that's much better.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-23 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-23 9:07 [Qemu-devel] [PATCH] isa: serial+parallel: fixup index property Gerd Hoffmann
2009-11-23 10:01 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).