From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nbzgk-0001Cu-B9
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 12:03:50 -0500
Received: from [199.232.76.173] (port=56874 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nbzgj-0001CY-R3
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 12:03:49 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <armbru@redhat.com>) id 1Nbzgi-0004YL-BM
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 12:03:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59436)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1Nbzgi-0004Y9-0N
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 12:03:48 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/8] QError: Add QMP mode-oriented errors
References: <1264686180-29845-1-git-send-email-lcapitulino@redhat.com>
	<1264686180-29845-4-git-send-email-lcapitulino@redhat.com>
	<4B62145C.5060809@codemonkey.ws> <20100128223828.28928eeb@doriath>
Date: Mon, 01 Feb 2010 18:03:40 +0100
In-Reply-To: <20100128223828.28928eeb@doriath> (Luiz Capitulino's message of
	"Thu, 28 Jan 2010 22:38:28 -0200")
Message-ID: <m3pr4onb0z.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Thu, 28 Jan 2010 16:49:00 -0600
> Anthony Liguori <anthony@codemonkey.ws> wrote:
>
>> On 01/28/2010 07:42 AM, Luiz Capitulino wrote:
>> > Two new errors:
>> >
>> > - QERR_QMP_INVALID_MODE_NAME
>> > - QERR_QMP_INVALID_MODE_TRANSITION
>> >
>> > Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
>> > ---
>> >   qerror.c |    8 ++++++++
>> >   qerror.h |    6 ++++++
>> >   2 files changed, 14 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/qerror.c b/qerror.c
>> > index 6c2aba0..d01354d 100644
>> > --- a/qerror.c
>> > +++ b/qerror.c
>> > @@ -113,6 +113,14 @@ static const QErrorStringTable qerror_table[] = {
>> >           .desc      = "Bad QMP input object",
>> >       },
>> >       {
>> > +        .error_fmt = QERR_QMP_INVALID_MODE_NAME,
>> > +        .desc      = "Mode name %(name) is invalid",
>> > +    },
>> >    
>> 
>> This is basically, invalid parameter, no?
>
>  Yeah.

Then let's use that.