From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mm3i2-0005T1-EN
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 06:50:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mm3hx-0005S4-Oz
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 06:50:30 -0400
Received: from [199.232.76.173] (port=40674 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mm3hx-0005S1-JH
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 06:50:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1026)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1Mm3hx-0000rX-4C
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 06:50:25 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <498439EA-7D59-4E25-BD33-26AB8F124388@nokia.com> (Juha
	Riihimaki's message of "Fri, 11 Sep 2009 12:31:30 +0200")
References: <cover.1252662256.git.quintela@redhat.com>
	<498439EA-7D59-4E25-BD33-26AB8F124388@nokia.com>
Date: Fri, 11 Sep 2009 12:47:39 +0200
Message-ID: <m3pr9xzrjo.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 00/20] VMState: port all i2c devices
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juha.Riihimaki@nokia.com
Cc: qemu-devel@nongnu.org

<Juha.Riihimaki@nokia.com> wrote:
> Hi,
>
> On Sep 11, 2009, at 13:10, ext Juan Quintela wrote:
>
>> - i2c->address now are uint8_t, my review of all uses is that they  
>> are always
>>  used as uint8_t (and that is the type that is passed on the  
>> value).  If you know
>>  i2c, please check.  Change 0002 looks big, but it is because as I was
>
> I would propose that the address has more than 8 bits to be more  
> future-proof. After all, the bus addressing has already been extended  
> to 10 bits: see http://www.i2c-bus.org/addressing/10-bit-addressing/

Then we have a field day, and make incompatible versions from now on.
VMState use typechecking to make sure that what we save/load has the
same type that the variable.  And that was not the case for i2c
addresses.  how many users have old machines saved that they want to restore?

Later, Juan.

>
> Regards,
> Juha