From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mi9mn-0006qH-FD
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 12:31:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mi9mi-0006nM-K1
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 12:31:16 -0400
Received: from [199.232.76.173] (port=42139 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mi9mi-0006nH-Dd
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 12:31:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46251)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1Mi9mh-0007Nl-S7
	for qemu-devel@nongnu.org; Mon, 31 Aug 2009 12:31:12 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <20090831131812.57f12e52@doriath> (Luiz Capitulino's message of
	"Mon, 31 Aug 2009 13:18:12 -0300")
References: <20090831131812.57f12e52@doriath>
Date: Mon, 31 Aug 2009 18:28:42 +0200
Message-ID: <m3prac2bid.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH] configure: fix Linux AIO detection
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> wrote:
> We should set $linux_aio to 'no' if detection failed, otherwise
> its contents will be empty, which is a bug as we test for 'yes'
> or 'no'.
>     
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

acked-by: Juan Quintela <quintela@redhat.com>
Good catch.

> diff --git a/configure b/configure
> index b805f10..4c60c4d 100755
> --- a/configure
> +++ b/configure
> @@ -1327,6 +1327,7 @@ EOF
>      if test "$linux_aio" = "yes" ; then
>        feature_not_found "linux AIO"
>      fi
> +    linux_aio=no
>    fi
>  fi
>