From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42097 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2Plo-0001x2-EO for qemu-devel@nongnu.org; Wed, 23 Mar 2011 11:14:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q2Pll-0001ak-HT for qemu-devel@nongnu.org; Wed, 23 Mar 2011 11:14:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q2Pll-0001aW-4c for qemu-devel@nongnu.org; Wed, 23 Mar 2011 11:14:45 -0400 From: Juan Quintela In-Reply-To: (Peter Maydell's message of "Wed, 23 Mar 2011 14:36:41 +0000") References: <1300839376-22520-1-git-send-email-aliguori@us.ibm.com> <1300839376-22520-12-git-send-email-aliguori@us.ibm.com> Date: Wed, 23 Mar 2011 16:13:02 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 11/11] test-vmstate: add test case to verify we don't change VMState Reply-To: quintela@redhat.com List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Jan Kiszka , Anthony Liguori , qemu-devel@nongnu.org Peter Maydell wrote: > On 23 March 2011 14:19, Juan Quintela wrote: >> Peter Maydell wrote: >> ARM people are sending lots of vmstate changes, I guess/hope that >> somebody is trying to get it working. >> >> /me looks at Peter O:-), hint, hint, ... > > Well, the main thing I care about currently (or did back before > Christmas which is when I sent a patchset to add save/restore > to a pile of ARM devices) is simple save-and-restore for debugging > use. The rest is just that patches don't get through code review > unless they get the vmstate stuff right, and I care about not > being rejected :-) > > I think it's still the case that there are devices in > some of the ARM devboards with no save/restore support > at all. I would really prefer it if the default for a > device was "I do not support this" with the things like > USB where somebody has audited them as genuinely needing > no save/restore code explicitly marked as "this is OK"; > then we could easily determine what needed fixing and > not offer a broken facility to users. I agree, but that means (again), review of all devices to change the defaults. It is on my ToDo list (but my ToDo list is huge :-( >> Any idea if there are images for testing ARM? > > There are prebuilt images on Aurelien's website for > ARM and others, which is the simplest thing: > http://www.aurel32.net/info/debian_arm_qemu.php That images don't migrate for me at all. Guest got hung after migration, at least some state (probably irq's) are not passed correctly. Later, Juan.