[Qemu-devel] Re: [PATCH 25/29] Add check support

[Juan Quintela <quintela@redhat.com>]

Luiz Capitulino <lcapitulino@redhat.com> wrote:
> On Wed, 26 Aug 2009 21:34:20 +0200
> Juan Quintela <quintela@redhat.com> wrote:
>
>> Luiz Capitulino <lcapitulino@redhat.com> wrote:
>> > Check is a unit testing framework for C.
>> 
>> Some notes.  Configuration has changed to be a bit more consistent.
>> Below I change the configuration bits to new style.
>> 
>> Can I suggest that you name the configuration something different?
>> 
>> CONFIG_CHECK
>> 
>> means whatever, some for "check" variable in configure.
>> 
>> check_suite
>> test_suite
>> 
>> or anything else?
>
>  CONFIG_CHECK_UTESTS or CONFIG_UTESTS will do, I think.

That works for me.

>  Although it might be important to keep '--enable-check' as
> a configure option, because the library itself is called
> 'check'.

For coherence I will call it --enable-check-utests.


>> > +ifdef CONFIG_CHECK
>> > +LIBS += $(CHECK_LIBS)
>> > +endif
>> 
>> We changed how to add libraries, you can remove this three lines.
>> See below where to add it.
>
>  Ok, but you are talking about code in staging right?

No, we are moving everything to this style.  In staging are the changes
for the other stuff in qemu.

>  As I told you on IRC, I'm a bit reluctant to change a patchset based
> on upstream master to rely on something that's on staging.

This is a change that everything is suffering.  No dependencies on
staging at all.  The code that I showed you works today :)

>> I guess you want to add something here to tools, otherwise, you are
>> doing nothing here :)
>
>  It just adds infrastructure that will be used by the following
> patches.

ah, ok. didn't looked more, sorry.

Later, Juan.