From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MfZ3e-0001wN-05
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:53:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MfZ3Z-0001qc-Cx
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:53:57 -0400
Received: from [199.232.76.173] (port=37813 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MfZ3Z-0001qE-8V
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:53:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10285)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1MfZ3V-0000ZZ-SO
	for qemu-devel@nongnu.org; Mon, 24 Aug 2009 08:53:51 -0400
Received: from int-mx07.intmail.prod.int.phx2.redhat.com
	(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.20])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7OCrmxo013338
	for <qemu-devel@nongnu.org>; Mon, 24 Aug 2009 08:53:49 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <4A928A3B.4090207@redhat.com> (Gerd Hoffmann's message of "Mon,
	24 Aug 2009 14:40:27 +0200")
References: <cover.1251111439.git.quintela@redhat.com>
	<9052e745819c03d86640f258f86e2a5e9424d55c.1251111439.git.quintela@redhat.com>
	<4A928A3B.4090207@redhat.com>
Date: Mon, 24 Aug 2009 14:51:27 +0200
Message-ID: <m3skfhnzn4.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 07/22] ne2000: Remove unneeded
	double	indirection of PCINE2000State
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> wrote:
>>   typedef struct NE2000State {
>> +    PCIDevice dev;
>>       uint8_t cmd;
>
>> -typedef struct PCINE2000State {
>> -    PCIDevice dev;
>> -    NE2000State ne2000;
>> -} PCINE2000State;
>
> NACK.
>
> We'll have a ...
>
> typedef struct ISANE2000State {
>    ISADevice dev;
>    NE2000State ne2000;
> } ISANE2000State;
>
> ... some day.

Ok, redoing it this way.
Thanks for the review.

Later, Juan.