From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MW6mw-0004kB-5s
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 06:53:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MW6mr-0004iJ-7Z
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 06:53:37 -0400
Received: from [199.232.76.173] (port=43482 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MW6mr-0004hu-0v
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 06:53:33 -0400
Received: from mx2.redhat.com ([66.187.237.31]:60687)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1MW6mq-0004eh-HX
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 06:53:32 -0400
In-Reply-To: <20090729041328.GA21358@fries.net> (Todd T. Fries's message of
	"Tue\, 28 Jul 2009 23\:13\:28 -0500")
References: <cover.1248703754.git.quintela@redhat.com>
	<2363021676118ae5969d34d264f9c68e58731841.1248703754.git.quintela@redhat.com>
	<20090729041328.GA21358@fries.net>
From: Juan Quintela <quintela@redhat.com>
Date: Wed, 29 Jul 2009 12:51:34 +0200
Message-ID: <m3skgf92yx.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 16/47] O_LARGEFILE is already set in
	qemu-common.h
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: todd@fries.net
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

"Todd T. Fries" <qemu@email.fries.net> wrote:
> Stupid observation here, if you renamed 'HOST_BSD' to 'CONFIG_BSD'
> didn't you miss something below?
>
> Penned by Juan Quintela on 20090727 16:12.55, we have:
> | 
> | Signed-off-by: Juan Quintela <quintela@redhat.com>
> | ---
> |  configure |    1 -
> |  1 files changed, 0 insertions(+), 1 deletions(-)
> | 
> | diff --git a/configure b/configure
> | index 3c5fb6e..be00e28 100755
> | --- a/configure
> | +++ b/configure
> | @@ -1746,7 +1746,6 @@ fi
> | 
> |  # XXX: suppress that
> |  if [ "$bsd" = "yes" ] ; then
> | -  echo "#define O_LARGEFILE 0" >> $config_host_h
> |    echo "#define MAP_ANONYMOUS MAP_ANON" >> $config_host_h
> |    echo "#define HOST_BSD 1" >> $config_host_h
> |  fi
> | -- 
> | 1.6.2.5
> | 
> | 

It is done later in the series, I saw it as CONFIG_BSD in upstream.

Thanks, Juan.