From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40923 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PAgQT-0006SF-IC
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 06:06:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1PAgI0-0004l8-W8
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 05:57:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10311)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1PAgI0-0004l3-Pp
	for qemu-devel@nongnu.org; Tue, 26 Oct 2010 05:57:56 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com
	(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o9Q9vt4a021368
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 26 Oct 2010 05:57:56 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] Add get_dev_path callback to ISA bus.
References: <1287928933-11423-1-git-send-email-gleb@redhat.com>
	<m362wqtijs.fsf@blackfin.pond.sub.org>
	<20101025170007.GC31633@redhat.com>
	<m3pquyi2fu.fsf@blackfin.pond.sub.org>
	<20101025180610.GA877@redhat.com>
Date: Tue, 26 Oct 2010 11:57:53 +0200
In-Reply-To: <20101025180610.GA877@redhat.com> (Gleb Natapov's message of
	"Mon, 25 Oct 2010 20:06:10 +0200")
Message-ID: <m3tyk99sym.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: qemu-devel@nongnu.org

Gleb Natapov <gleb@redhat.com> writes:

> On Mon, Oct 25, 2010 at 07:53:41PM +0200, Markus Armbruster wrote:
>> Gleb Natapov <gleb@redhat.com> writes:
>> 
>> > On Mon, Oct 25, 2010 at 05:10:15PM +0200, Markus Armbruster wrote:
>> >> Gleb Natapov <gleb@redhat.com> writes:
>> >> 
>> >> > PCI bus already has one. For ISA bus this patch series uses device's
>> >> > ioports to uniquely describe it. For isa-ide, for example, get_dev_path
>> >> > method returns:
>> >> > 01f0-01f7,03f6 for first IDE controller
>> >> > 0170-0177,0376 for second one
>> >> 
>> >> Any I/O port used by the device identifies it.  I'd say a common
>> >> identifier is the "I/O base", the lowest I/O port used.
>> > So use only first port from the string. More information is better then
>> > less information. You can always drop information you do not need.
>> 
>> I'd prefer canonical bus addresses to be terse.  It's not the place to
>> give additional information.
>
> I'd prefer them to give full info but not more. I don't see why you
> point is more valid then mine.

Full information about ISA resources is more than I/O ports, it also
includes IRQs and DMA channels.

An address is not the place to give full information.  The purpose of an
address is to name a thing, not to give full information about that
thing.


By the way, get_dev_path() really needs a written contract.  Actually,
all the qdev and qbus callbacks do.