From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NY03q-00061I-JF
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 11:39:10 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NY03l-0005rl-IG
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 11:39:10 -0500
Received: from [199.232.76.173] (port=35555 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NY03l-0005rR-B4
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 11:39:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48592)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NY03k-0006VX-R7
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 11:39:05 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev: Add help for device properties
References: <4B54B749.5080304@mail.berlios.de>
	<1264024715-23417-1-git-send-email-weil@mail.berlios.de>
Date: Thu, 21 Jan 2010 17:38:58 +0100
In-Reply-To: <1264024715-23417-1-git-send-email-weil@mail.berlios.de> (Stefan
	Weil's message of "Wed, 20 Jan 2010 22:58:33 +0100")
Message-ID: <m3vdevs999.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Stefan Weil <weil@mail.berlios.de> writes:

> When called with property "?", a list of supported
> properties will be printed (instead of an error message).
>
> This is useful for command lines like
> 	qemu -device e1000,?
> and was already standard for other options like model=?
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  hw/qdev-properties.c |   15 +++++++++++++--
>  1 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
> index 277ff9e..8547ad2 100644
> --- a/hw/qdev-properties.c
> +++ b/hw/qdev-properties.c
> @@ -544,8 +544,19 @@ int qdev_prop_parse(DeviceState *dev, const char *name, const char *value)
>  
>      prop = qdev_prop_find(dev, name);
>      if (!prop) {
> -        fprintf(stderr, "property \"%s.%s\" not found\n",
> -                dev->info->name, name);
> +        if (strcmp(name, "?") != 0) {
> +            fprintf(stderr, "property \"%s.%s\" not found\n",
> +                    dev->info->name, name);
> +        } else {
> +            fprintf(stderr, "supported properties:\n");
> +            if (dev->info->props != NULL) {
> +                Property *props = dev->info->props;
> +                while (props->name) {
> +                    fprintf(stderr, "%s.%s\n", dev->info->name, props->name);
> +                    props++;
> +                }
> +            }
> +        }
>          return -1;
>      }
>      if (!prop->info->parse) {

I like it.