From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55898)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QzV1m-0002Qa-7w
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 10:47:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QzV1k-0008Ur-Va
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 10:47:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39946)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QzV1k-0008SO-Lp
	for qemu-devel@nongnu.org; Fri, 02 Sep 2011 10:47:28 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1312376904-16115-1-git-send-email-armbru@redhat.com>
	<1312376904-16115-10-git-send-email-armbru@redhat.com>
	<4E60ADEC.3070903@redhat.com>
Date: Fri, 02 Sep 2011 16:47:23 +0200
In-Reply-To: <4E60ADEC.3070903@redhat.com> (Kevin Wolf's message of "Fri, 02
	Sep 2011 12:20:28 +0200")
Message-ID: <m3wrdrgfwk.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH v2 09/45] ide/atapi: Clean up misleading
	name in cmd_start_stop_unit()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: stefano.stabellini@eu.citrix.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, hare@suse.de, amit.shah@redhat.com, hch@lst.de

Kevin Wolf <kwolf@redhat.com> writes:

> Am 03.08.2011 15:07, schrieb Markus Armbruster:
>> "eject" is misleading; it means "eject" when start is clear, but
>> "load" when start is set.  Rename to loej, because that's how MMC-5
>> calls it, in section 6.40.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  hw/ide/atapi.c |    8 ++++----
>>  1 files changed, 4 insertions(+), 4 deletions(-)
>> 
>> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
>> index fe2fb0b..17fbef8 100644
>> --- a/hw/ide/atapi.c
>> +++ b/hw/ide/atapi.c
>> @@ -892,11 +892,11 @@ static void cmd_seek(IDEState *s, uint8_t* buf)
>>  
>>  static void cmd_start_stop_unit(IDEState *s, uint8_t* buf)
>>  {
>> -    int start, eject, sense, err = 0;
>> -    start = buf[4] & 1;
>> -    eject = (buf[4] >> 1) & 1;
>> +    int sense, err = 0;
>> +    bool start = buf[4] & 1;
>> +    bool loej = buf[4] & 2;
>>  
>> -    if (eject) {
>> +    if (loej) {
>>          err = bdrv_eject(s->bs, !start);
>>      }
>>  
>
> "eject" has the advantage that I immediately know that it's something to
> do with the tray. "loej" on the other hand is a sequence of four random
> characters. Maybe add a comment?

The name "loej" comes from MMC-5.  I can add a comment to its
definition.