From: Juan Quintela <quintela@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: QEMU-devel Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] Re: [PATCH 01/17] Only build ivshmem when CONFIG_PCI && CONFIG_KVM
Date: Thu, 24 Mar 2011 22:46:29 +0100 [thread overview]
Message-ID: <m3wrjodwei.fsf@neno.mitica> (raw)
In-Reply-To: <1300982333-12802-2-git-send-email-agraf@suse.de> (Alexander Graf's message of "Thu, 24 Mar 2011 16:58:37 +0100")
Alexander Graf <agraf@suse.de> wrote:
> The ivshmem depends on PCI and KVM, not only KVM. Reflect this
> in the Makefile, so we don't get build errors on s390x.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> Makefile.target | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index f0df98e..17ad396 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -209,7 +209,13 @@ QEMU_CFLAGS += $(VNC_PNG_CFLAGS)
> obj-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
>
> # Inter-VM PCI shared memory
> -obj-$(CONFIG_KVM) += ivshmem.o
> +CONFIG_IVSHMEM =
> +ifeq ($(CONFIG_KVM), y)
> + ifeq ($(CONFIG_PCI), y)
> + CONFIG_IVSHMEM = y
> + endif
> +endif
> +obj-$(CONFIG_IVSHMEM) += ivshmem.o
This shouldn't be here. Proper place is at ./configure, or better yet
at defaults/x86_64-softmmu.mak
CONFIG_IVSHMEM=y
It is complicated though, because we depend on PCI and KVM.
Later, Juan.
next prev parent reply other threads:[~2011-03-24 21:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 15:58 [Qemu-devel] [PATCH 00/17] s390x emulation support Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 01/17] Only build ivshmem when CONFIG_PCI && CONFIG_KVM Alexander Graf
2011-03-24 21:46 ` Juan Quintela [this message]
2011-03-25 11:04 ` [Qemu-devel] " Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 02/17] virtio: use generic name when possible Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 03/17] s390x: Enable disassembler for s390x Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 04/17] s390x: Enable nptl " Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 05/17] s390x: enable CPU_QuadU Alexander Graf
2011-03-24 16:52 ` Peter Maydell
2011-03-24 16:54 ` Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 06/17] s390x: s390x-linux-user support Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 07/17] linux-user: define a couple of syscalls for non-uid16 targets Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 08/17] s390x: Enable s390x-softmmu target Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 09/17] s390x: Dispatch interrupts to KVM or the real CPU Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 10/17] s390x: Adjust GDB stub Alexander Graf
2011-03-25 12:07 ` Nathan Froyd
2011-03-25 12:16 ` Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 11/17] s390x: virtio machine storage keys Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 12/17] s390x: Prepare cpu.h for emulation Alexander Graf
2011-03-28 14:54 ` Peter Maydell
2011-03-29 10:14 ` Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 13/17] s390x: helper functions for system emulation Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 14/17] s390x: Implement opcode helpers Alexander Graf
2011-03-24 17:29 ` Peter Maydell
2011-03-24 17:41 ` Richard Henderson
2011-03-24 18:09 ` Alexander Graf
2011-03-24 18:13 ` Alexander Graf
2011-03-28 17:23 ` Alexander Graf
2011-03-28 17:42 ` Richard Henderson
2011-03-28 17:55 ` Peter Maydell
2011-03-29 9:04 ` Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 15/17] s390x: Adjust internal kvm code Alexander Graf
2011-03-24 15:58 ` [Qemu-devel] [PATCH 16/17] s390x: translate engine for s390x CPU Alexander Graf
2011-03-28 15:40 ` Peter Maydell
2011-03-29 8:55 ` Alexander Graf
2011-03-29 9:17 ` Peter Maydell
2011-03-29 9:25 ` Alexander Graf
2011-03-29 9:56 ` Peter Maydell
2011-03-29 10:40 ` Alexander Graf
2011-03-31 10:37 ` Peter Maydell
2011-03-24 15:58 ` [Qemu-devel] [PATCH 17/17] s390x: build s390x by default Alexander Graf
2011-03-28 14:20 ` [Qemu-devel] [PATCH 00/17] s390x emulation support Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wrjodwei.fsf@neno.mitica \
--to=quintela@redhat.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).