From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47627 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q2sOO-0002Lq-Oq
	for qemu-devel@nongnu.org; Thu, 24 Mar 2011 17:48:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Q2sON-0007vg-Ar
	for qemu-devel@nongnu.org; Thu, 24 Mar 2011 17:48:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7578)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Q2sOM-0007vW-Tj
	for qemu-devel@nongnu.org; Thu, 24 Mar 2011 17:48:31 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1300982333-12802-2-git-send-email-agraf@suse.de> (Alexander
	Graf's message of "Thu, 24 Mar 2011 16:58:37 +0100")
References: <1300982333-12802-1-git-send-email-agraf@suse.de>
	<1300982333-12802-2-git-send-email-agraf@suse.de>
Date: Thu, 24 Mar 2011 22:46:29 +0100
Message-ID: <m3wrjodwei.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 01/17] Only build ivshmem when CONFIG_PCI
	&& CONFIG_KVM
Reply-To: quintela@redhat.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: QEMU-devel Developers <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

Alexander Graf <agraf@suse.de> wrote:
> The ivshmem depends on PCI and KVM, not only KVM. Reflect this
> in the Makefile, so we don't get build errors on s390x.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  Makefile.target |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index f0df98e..17ad396 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -209,7 +209,13 @@ QEMU_CFLAGS += $(VNC_PNG_CFLAGS)
>  obj-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
>  
>  # Inter-VM PCI shared memory
> -obj-$(CONFIG_KVM) += ivshmem.o
> +CONFIG_IVSHMEM =
> +ifeq ($(CONFIG_KVM), y)
> +  ifeq ($(CONFIG_PCI), y)
> +    CONFIG_IVSHMEM = y
> +  endif
> +endif
> +obj-$(CONFIG_IVSHMEM) += ivshmem.o

This shouldn't be here.  Proper place is at ./configure, or better yet
at defaults/x86_64-softmmu.mak

CONFIG_IVSHMEM=y

It is complicated though, because we depend on PCI and KVM.

Later, Juan.