From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58613 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PLCye-0004lc-IG
	for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:54:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PLCxl-0000R7-UQ
	for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:53:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43026)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PLCxl-0000QY-GV
	for qemu-devel@nongnu.org; Wed, 24 Nov 2010 05:52:33 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <20101124104035.GB23493@redhat.com> (Michael S. Tsirkin's message
	of "Wed, 24 Nov 2010 12:40:35 +0200")
References: <cover.1290552026.git.quintela@redhat.com>
	<a12e21918775e0c0ae23c373be1e35060b52031b.1290552026.git.quintela@redhat.com>
	<20101124104035.GB23493@redhat.com>
Date: Wed, 24 Nov 2010 11:52:25 +0100
Message-ID: <m3wro3dmdy.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Nov 24, 2010 at 12:02:59AM +0100, Juan Quintela wrote:
>> From: Juan Quintela <quintela@trasno.org>

>> diff --git a/buffered_file.h b/buffered_file.h
>> index 98d358b..a728316 100644
>> --- a/buffered_file.h
>> +++ b/buffered_file.h
>> @@ -21,6 +21,8 @@ typedef void (BufferedPutReadyFunc)(void *opaque);
>>  typedef void (BufferedWaitForUnfreezeFunc)(void *opaque);
>>  typedef int (BufferedCloseFunc)(void *opaque);
>> 
>> +extern const int buffered_file_interval;
>> +
>
> This shouldn't be exported, IMO.

What do you want?  an accessor function?  Notice that it is a constant.
We need the value in other places, see the last patch.

Otherwise, I have to pick random numbers like ... 50ms.

Later, Juan.


>
>>  QEMUFile *qemu_fopen_ops_buffered(void *opaque, size_t xfer_limit,
>>                                    BufferedPutFunc *put_buffer,
>>                                    BufferedPutReadyFunc *put_ready,
>> -- 
>> 1.7.3.2
>>