From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyA5t-0007lF-T1 for qemu-devel@nongnu.org; Wed, 14 Oct 2009 16:05:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyA5p-0007kQ-Ap for qemu-devel@nongnu.org; Wed, 14 Oct 2009 16:05:09 -0400 Received: from [199.232.76.173] (port=55990 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyA5p-0007kN-7U for qemu-devel@nongnu.org; Wed, 14 Oct 2009 16:05:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26232) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MyA5o-0000sV-JO for qemu-devel@nongnu.org; Wed, 14 Oct 2009 16:05:04 -0400 From: Juan Quintela In-Reply-To: (andrzej zaborowski's message of "Wed, 14 Oct 2009 21:42:18 +0200") References: Date: Wed, 14 Oct 2009 22:04:36 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH 12/16] vmware_vga: remove !EMBED_STDVGA code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: andrzej zaborowski Cc: qemu-devel@nongnu.org andrzej zaborowski wrote: > 2009/10/14 Juan Quintela : >> andrzej zaborowski wrote: >>> 2009/10/14 Juan Quintela : >>>> It don't compile. =C2=A0And the trivial fixes (change vga.foo field to= foo field >>>> don't work either. =C2=A0No output >>> >>> Just a note that there's supposed to be no output because your guest >>> OS (and BIOS) expect the standard VGA functionality to be there. =C2=A0= The >>> define is only useful for debugging vmware_vga or OS driver. =C2=A0It's= ok >>> to drop it if you want. >> >> I preffer to drop it because it has no chance of working (suspend/resume >> code is not there for instance). >> >> Once that we are there. =C2=A0I did a fast try at enabling DIRECT_VRAM w= ith >> the same not working result. =C2=A0Any idea if it would make things >> better/fast/... whatever? > > Currently it probably makes things slower. I have not digged through > the newer SDL code deep enough, to tell if it's possible to create a > SDL surface directly from guest RAM provided it's contiguously mapped > on host -- this is what VMware does and it's one of the expected > benefits from using vmware_vga that isn't there, and I think using DGA > saves them another unneeded copy. This would need reimplementing the > pieces guarded by #ifdef DIRECT_VRAM. Without DIRECT_VRAM, my un-scientific test (run glxgears) show that cirrus_vga is a bit faster (207 vs 190 fps), neither the test of the results something to write home about. I have another problem with the driver: depth. I have to change s->depth to 32 in vmsvga_reset() to make it work correctly on my setup (default qemu.git tree, i.e. nothing fancy), running with sdl. Any clue here? Anthony thinks that the problem happens at the memcpy() in vmsvga_update_rect(), but I haven't had the time to look at how to fix it. Any idea here? Later, Juan.