[Qemu-devel] Re: optional feature

[Juan Quintela <quintela@redhat.com>]

"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Sep 16, 2009 at 03:01:22PM +0200, Juan Quintela wrote:
>> >> > pci config is on vmstate already, I don't see a problem here.
>> >> 
>> >> vmstate don't understand pci config.
>> >
>> > How can it save it then? What's more, how can it load it sanely? E.g.
>> > when loading we must make sure that device id etc match.
>> 
>> We don't test it at all.
>
> Someone has to. Existing code has it.  Removing this sanity check and
> changing e.g. device id by load will be a bad thing.

Is there anything else that the code that I posted in the other email?
I didn't removed any check.  I haven't removed any check that existed
before when I ported VMState.  I only removed some support for very old
versions that didn't work at all (ram device comes to mind).  If you see
that I removed any other check, let me know and I will put it back.

Later, Juan.