From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MnueV-00011p-Oa
	for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:34:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MnueR-0000zA-3Q
	for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:34:31 -0400
Received: from [199.232.76.173] (port=40855 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MnueQ-0000z0-SS
	for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:34:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49432)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1MnueQ-0005JA-7h
	for qemu-devel@nongnu.org; Wed, 16 Sep 2009 09:34:26 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <20090916130304.GB4795@redhat.com> (Michael S. Tsirkin's message
	of "Wed, 16 Sep 2009 16:03:04 +0300")
References: <20090916104620.GA4456@redhat.com> <m34or3up58.fsf@neno.mitica>
	<20090916111845.GJ23157@redhat.com> <m3ocpbt8j0.fsf@neno.mitica>
	<20090916115224.GA4628@redhat.com> <m3fxant7br.fsf@neno.mitica>
	<20090916121818.GA4710@redhat.com> <m37hvzt6r1.fsf@neno.mitica>
	<20090916123710.GB4729@redhat.com> <m3fxanrql9.fsf@neno.mitica>
	<20090916130304.GB4795@redhat.com>
Date: Wed, 16 Sep 2009 15:34:21 +0200
Message-ID: <m3y6ofm2si.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: optional feature
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>

"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Sep 16, 2009 at 03:01:22PM +0200, Juan Quintela wrote:
>> >> > pci config is on vmstate already, I don't see a problem here.
>> >> 
>> >> vmstate don't understand pci config.
>> >
>> > How can it save it then? What's more, how can it load it sanely? E.g.
>> > when loading we must make sure that device id etc match.
>> 
>> We don't test it at all.
>
> Someone has to. Existing code has it.  Removing this sanity check and
> changing e.g. device id by load will be a bad thing.

Is there anything else that the code that I posted in the other email?
I didn't removed any check.  I haven't removed any check that existed
before when I ported VMState.  I only removed some support for very old
versions that didn't work at all (ram device comes to mind).  If you see
that I removed any other check, let me know and I will put it back.

Later, Juan.