From: Vincent Bernat <vincent@bernat.im>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PULL] tftp: fake support for netascii protocol
Date: Sun, 20 Nov 2016 09:42:46 +0100 [thread overview]
Message-ID: <m3zikufsop.fsf@luffy.cx> (raw)
In-Reply-To: <20161119223003.GD10378@var.home> (Samuel Thibault's message of "Sat, 19 Nov 2016 23:30:03 +0100")
❦ 19 novembre 2016 23:30 +0100, Samuel Thibault <samuel.thibault@gnu.org> :
>> > I think you should at least issue a qemu_log_mask(LOG_UNIMP, "...")
>> > call in that case.
>>
>> I can do that if needed.
>
> That'd be better indeed. Otherwise people might wonder why things are
> not working. Warning that they have to do the LF -> CR,LF conversion by
> hand is important here.
I have sent an updated patch for that.
Totally unrelated, but on Debian, I have to use -r instead of -Wl,r for
LD_REL. This is explained here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837574
I don't think the patch has been forwarded to you yet.
--
Don't patch bad code - rewrite it.
- The Elements of Programming Style (Kernighan & Plauger)
next prev parent reply other threads:[~2016-11-20 8:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 17:51 [Qemu-devel] [PULL] tftp: fake support for netascii protocol Samuel Thibault
2016-11-18 17:51 ` Samuel Thibault
2016-11-18 17:55 ` no-reply
2016-11-19 7:32 ` Thomas Huth
2016-11-19 8:03 ` Vincent Bernat
2016-11-19 22:30 ` Samuel Thibault
2016-11-20 8:41 ` [Qemu-devel] [v2] " Vincent Bernat
2016-11-20 8:44 ` no-reply
2016-11-20 8:44 ` no-reply
2016-11-21 7:35 ` Thomas Huth
2016-11-21 14:46 ` Stefan Hajnoczi
2016-11-21 14:51 ` hpa
2016-11-21 15:05 ` Samuel Thibault
2016-11-21 15:28 ` hpa
2016-11-22 10:49 ` Stefan Hajnoczi
2016-11-23 7:30 ` Vincent Bernat
2016-11-23 9:34 ` Stefan Hajnoczi
2016-11-21 15:35 ` Vincent Bernat
2016-11-21 15:38 ` hpa
2016-11-20 8:42 ` Vincent Bernat [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-20 17:05 [Qemu-devel] [PULL] " Samuel Thibault
2016-11-20 17:05 ` Samuel Thibault
2016-11-20 17:09 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zikufsop.fsf@luffy.cx \
--to=vincent@bernat.im \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@gnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).